← Back to team overview

kicad-developers team mailing list archive

Patch to fix a boundary box bug


--0016e65aedc4534d62047891c4f6 Content-Type: text/plain; charset=ISO-8859-1

Hi Guys,

The "bug" that I am seeing is that text fields are included in a
component boundary box, even if they are invisible. This might have
something to do with the fact that I have the "Value" field invisible
in these components as I used Field 1 as the real component value. I
think it makes more sense to exclude invisble text fields from the
components boundary box. Some wiring was hard or impossible for me to
select. I don't think this patch will have any negative effect, and
invisible elements shouldn't be in the bounding box.

The patch ignores all component fields that are invisble in GetBoundaryBox()

Thinking a bit further, do the fields need to be in the component
boundary box at all? I can see places where I might have some fields
that would stop me selecting wires because they increase the part's
boundary box beyond the pin+graphic extents. I tried excluding all
text fields, and it appeared to work fine for me, selection of
everything was easy and the accuracy of selection should be best by
excluding all text fields.

I have attached some screen shots of the boundary boxes for the
different options.

Best Regards,

 --0016e65aedc4534d62047891c4f6 Content-Type: application/octet-stream; name="boundingbox.patch"
Content-Disposition: attachment; filename="boundingbox.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g24qurh20

[Attachment content not displayed.] --0016e65aedc4534d62047891c4f6 Content-Type: image/jpeg; name="BoundingBoxAllTextExcl.jpg"
Content-Disposition: attachment; filename="BoundingBoxAllTextExcl.jpg"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g24qv6051

[Attachment content not displayed.] --0016e65aedc4534d62047891c4f6 Content-Type: image/jpeg; name="BoundingBoxBefore.jpg"
Content-Disposition: attachment; filename="BoundingBoxBefore.jpg"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g24qvdh62

[Attachment content not displayed.] --0016e65aedc4534d62047891c4f6 Content-Type: image/jpeg; name="BoundingBoxInsivibleTextExcl.jpg"
Content-Disposition: attachment; filename="BoundingBoxInsivibleTextExcl.jpg"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g24qvgq23

[Attachment content not displayed.] --0016e65aedc4534d62047891c4f6-- 

Follow ups