kicad-developers team mailing list archive

[Brian Sidebotham <brian.sidebotham@...>]

--0016e659f45a8e6cd10478819294 Content-Type: text/plain; charset=ISO-8859-1

Hi Guys,

The bug: Moving a pin in libedit results in the pin ending up in a
psuedo-random position. This is due to the pin moving code not setting
the start positions.

Please find a patch attached to fix a bug when moving a pin in
eeschema's libedit. I think this regression might have been caused by
the previous patch I did to fix some other issues with pin editing in
libedit.

I also think some of the code in editpin.cpp should be able to be
cleaned up because of the static vars being moved to the LIB_DRAW_ITEM
class. Unfortunately I'm under pressure to get a PCB design done so I
don't have enough time to do that tidying right now.

Equally, the static vars in symbdrw.cpp could be exposed globally
instead but it seemed to make more sense to add these vars to the
LIB_DRAW_ITEM class.

Best Regards,

Brian.
 --0016e659f45a8e6cd10478819294 Content-Type: application/octet-stream; name="pinmove.patch"
Content-Disposition: attachment; filename="pinmove.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g23lfjrc0

[Attachment content not displayed.] --0016e659f45a8e6cd10478819294--