kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

Re: class OUTPUTFORMATTER

I am not entirely happy with one public interface function:

   virtual const char* GetQuoteChar( const char* wrapee )

This function is in capable of doubling up the " characters internal to
the input string.

I think a good replacement is:

   virtual const char* Quote( std::string* wrappee )

This way a new string does not need to be created if the input string is
not in need of quoting.  If quoting is needed, caller's copy is
modified, but again, no new string is created.

The main body of code affected by this is specctra_export.cpp.

Heads up.  Achieving perfection, is a continuous process (of chasing a
moving target).