kicad-developers team mailing list archive

[Jerry Jacobs <xor.gate.engineering@xxxxxxxxx>]

On 09/01/2010 07:02 PM, jean-pierre charras wrote:
> Rafael Sokolowski (our german translator) sent me a patch for a new
> Kicad About dialog.
> I committed it in rev  2470.
> The look is very good.
> Old code is not removed (see basicframe.cpp to select old or new dialog).

If all the other people agree, you have my vote to remove the old code.

> See below his first mail.
> 
> Rafael Sokolowski a écrit :
>>>>
>>>> Hello Jean-Pierre,
>>>>
>>>> I have seen on the todo list that there is the wish to have an
>>>> unique looking about box under different platforms. I have created
>>>> one that looks quite the same by use of wxGtk or wxMSW but I have no
>>>> occasion to test it under OS X. The API of my version is very
>>>> similar as it is currently used in KiCad by initializing this
>>>> wxAboutDialogInfo object.

The "old" one crashed and now with this implemention it seems to work on
OS X. Also I attached a patch which enables the about dialog again in
the Application menu -> About. Which is standard for all Mac applications.

Screenshot: http://kicad.xor-gate.org/screenshots

(I hope the patch is in correct encoding as Dick asked some time ago, I
use thunderbird with default settings. It went wrong with the

>>> Thanks, Your About dialog is very good. So I am interested to
>>> integrate it in Kicad.

This is indeed a very nice dialog and is more clear than the ones I have
seen before in other projects.

Kind regards,
Jerry Jacobs
- http://xor-gate.org

=== modified file 'cvpcb/cvpcb.cpp'
--- cvpcb/cvpcb.cpp	2010-02-21 20:23:16 +0000
+++ cvpcb/cvpcb.cpp	2010-09-01 19:43:53 +0000
@@ -84,8 +84,8 @@
      /* WXMAC application specific */
 #ifdef __WXMAC__
 //	wxApp::SetExitOnFrameDelete(false);
-//	wxApp::s_macAboutMenuItemId = ID_KICAD_ABOUT;
-	wxApp::s_macPreferencesMenuItemId = ID_OPTIONS_SETUP;
+    wxApp::s_macAboutMenuItemId = ID_KICAD_ABOUT;
+    wxApp::s_macPreferencesMenuItemId = ID_OPTIONS_SETUP;
 #endif /* __WXMAC__ */
 
 

=== modified file 'eeschema/eeschema.cpp'
--- eeschema/eeschema.cpp	2010-08-28 18:02:24 +0000
+++ eeschema/eeschema.cpp	2010-09-01 19:39:45 +0000
@@ -120,8 +120,8 @@
     /* WXMAC application specific */
 #ifdef __WXMAC__
 //	wxApp::SetExitOnFrameDelete(false);
-//	wxApp::s_macAboutMenuItemId = ID_KICAD_ABOUT;
-	wxApp::s_macPreferencesMenuItemId = ID_OPTIONS_SETUP;
+    wxApp::s_macAboutMenuItemId = ID_KICAD_ABOUT;
+    wxApp::s_macPreferencesMenuItemId = ID_OPTIONS_SETUP;
 #endif /* __WXMAC__ */
 
     wxFileName             filename;

=== modified file 'kicad/kicad.cpp'
--- kicad/kicad.cpp	2010-05-29 18:34:18 +0000
+++ kicad/kicad.cpp	2010-09-01 19:51:12 +0000
@@ -82,8 +82,8 @@
     /* TODO fix SetExitOnFrameDelete */
 #ifdef __WXMAC__
 //	wxApp::SetExitOnFrameDelete(false);
-//	wxApp::s_macAboutMenuItemId = ID_KICAD_ABOUT;
-	wxApp::s_macPreferencesMenuItemId = ID_OPTIONS_SETUP;
+    wxApp::s_macAboutMenuItemId = ID_KICAD_ABOUT;
+    wxApp::s_macPreferencesMenuItemId = ID_OPTIONS_SETUP;
 #endif /* __WXMAC__ */
 
     WinEDA_MainFrame* frame;

=== modified file 'pcbnew/pcbnew.cpp'
--- pcbnew/pcbnew.cpp	2010-08-28 18:02:24 +0000
+++ pcbnew/pcbnew.cpp	2010-09-01 19:39:14 +0000
@@ -94,9 +94,8 @@
 {
     /* WXMAC application specific */
 #ifdef __WXMAC__
-
 //	wxApp::SetExitOnFrameDelete(false);
-//	wxApp::s_macAboutMenuItemId = ID_KICAD_ABOUT;
+    wxApp::s_macAboutMenuItemId = ID_KICAD_ABOUT;
     wxApp::s_macPreferencesMenuItemId = ID_OPTIONS_SETUP;
 #endif /* __WXMAC__ */