kicad-developers team mailing list archive

[Alex G <mr.nuke.me@xxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/28/2010 07:52 PM, Dick Hollenbeck wrote:
> On 09/28/2010 11:14 AM, Amir Mohammadkhani-Aminabadi wrote:
>> Amir Mohammadkhani-Aminabadi has proposed merging lp:~amir-mohammadkhani/kicad/ash into lp:kicad.
>>
>> Requested reviews:
>>   kicad-testing-committers (kicad-testing-committers)
>>
>>
>> Var. compile and cmake fixes for win/vs2010
>>   
> 
> I think we are reaching the point where we need a separate branch for
> visual c++.
> 
> Although in this specific case it seems like a patch could be made for
> CMake, not Kicad.
> 
> I have no interest in continuing to bend over for Visual C++. 
> 
> Another option is to simply drop support for it, which would be my first
> choice.
> 
> I say no to this patch.
> 
I'm sorry to just jump in, but what was the problem with Blinded C++ in
the first place?
Is it not compiling? I wouldn't like to see kicad deviate from standard
C/C++ (name your favorite standard), and if it doesn't, there shouldn't
be an issue with other compilers. If Blinded C++ is incapable of
handling the standards, then, and only then we shouldn't even consider
supporting it.

I've added
- -pedantic -std=c++98
to CMAKE_CXX_FLAGS and recompiled to see if everything was in order. The
amount of warnings I got is worrying. Most of the ones I was able to
catch were extra ";" or extra "," , or "long long" not being supported
by the standard.Kicad does not conform to standard C++, and it makes me
wonder whether there are more mundane warnings that I missed.

On a side note,
- -std=c++0x generates an error that's not even from a kicad file.

Shouldn't this be cleaned up before deciding if other compilers are crap?

Alex
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJMolTCAAoJEL0kPHNPXJJKT3QP/A+6cqq7O98sy59iPZ4Nz4CI
VT4A/WZahLfS7p79OWQ6TOoFba7eCMHPZGYMMhi06EQFOfRevypNYFEsO9+2hm+l
ybD0e5zHspwiAzErI96k/Iv4QuArKNRSXGBETaDM0ZM1iZo8Gxe6c+co6W5/7HRq
bR/GtJpD8ArCjR4CpiqkqrlplGWP/v4JHOuQhnQp0eHivosDKd1/dJEjbU01xyCs
LbR0MSX0A7rIYc8ZcqOm3EJ+DQFjGrXjHuNsC5T61YWB6vEw7ox6k4KXdAZp/u0W
FrJ2a4GkbWS4NtyZh4UxkXtlitUmCxm23TBN41/l0lgZ346LDwWocX+DeplXC5Wc
Xt3RWStf0uagLYpNh03KxBcDgesDk7MXH001qE5eQhZThbIxQw9Rd+vvMdxRFSJR
fS18EIjJzjRbIRkyy0OpySz72GMppMg/mp7DiA6t3Wq2UvnrBO1HxHwHlrYiSkYc
qCsTzysr7yGo2j5RFMGF16KfIw0qYWwqxVNy1gepbTdeU9G3o/qxzk8moQhAijn3
2p+KDpz0LJgFCMeEE9LLShm1XTm0GjA3nOmSs+z8TnmPdpTKU1trRKtvouJVzJZ2
T8F6fSQBi5Mjb852b+H5zkRR1fSjXr0p3TsBqWqaXbTbqik9eYCXtIzkJdEGuYPk
ecQgLep6zI8BcFDK0TeM
=0oNf
-----END PGP SIGNATURE-----