← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Ortographic mode for 3D viewer and minor cleanup

 

On 10/3/2010 11:35 AM, Alex G wrote:
> I didn't want to stay idle while everybody talked about the new library
> structure. Since that is above my paygrade at the moment, I did ne next
> best thing I could.
> 
> I've added a button in 3d-viewer to switch between perspective and
> ortographic projection modes. The icon is a big boring "O", but then
> artwork was never my strong point.
> I've also cleaned up some -pedantic errors that annoyingly filled up the
> virtual terminal.
> I also came across some files that used tabs instead of spaces, so I
> refactored them to use spaces.
> 
> I hope this fits the guidelines ( and I hope I did the bzr diff thingy
> correctly).

Alex,

Some of your code is formatted incorrectly.

if ( expression )

should be

if( expression )

The same is true with your for() statements as well.  Here is the link
to the preliminary version of the coding policy.

https://lists.launchpad.net/kicad-developers/msg05402.html

Wayne

> 
> Alex

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



Follow ups

References