← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Ortographic mode for 3D viewer and minor cleanup

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> Some of your code is formatted incorrectly.
> 
> if ( expression )
> 
> should be
> 
> if( expression )
> 
> The same is true with your for() statements as well.  Here is the link
> to the preliminary version of the coding policy.
> 
> https://lists.launchpad.net/kicad-developers/msg05402.html
> 
> Wayne
Sorry about that.

> Thanks.
> 
> Some files you have changed tabs to spaces are automatically created (*base.xx or *fbp.xx) by wxFormBuilder.
> Do not spend time to edit them: all changes will be lost next time a dialog will be modified.
> These files are not really intended to be read by a developer.
> 
> -- 
> Jean-Pierre CHARRAS 

I didn't know about that. Thanks for the info. I modified those files
that gave warnings with -pedantic (most were extra ";" or extra "," ),
so that's how I got to those. I won't touch those in the future. :)

Well, I guess it's back to the mud puddle. :P

Alex
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJMqNR7AAoJEL0kPHNPXJJKNXAP/34YZZUnmGgquL0J2lPVKg73
kvVszpkd4ErjbkQgdILsvBRqj6N20lgLbzAqANEkU2HDMZ0SZiuSaeMwICjKwnV1
hZW7uNWSbOcuFkp8zsTHCI6LYRTYClVL2Rn6vOPnVRVprfDtNOOhNgP5l/ChHFkj
GQjLt0xgvigWJTe9FUNybWbXNgSEBq39ZZeT5mmdMuCXDrDbCi9o9zstGrAfgnBs
A4blAUTdSe59zFQunbBGmskx+7iiAqvVmdlYovxSIS6oPxld7EFnK/HPufUdaTTe
j7xSKhXqfiU7aVnQk3ZI56zH0tmbQZmWAELC36FjwzhjbNOXI5qULJCWJi2OCJcG
lHVIH9tENcrdLneZwntb/Z7m+cBnvKNPCDXQjBD5mZfrXH87IiCWqxCwWfUW2m8m
FnhsnzC94Oqp4ZJnDdODiAXdefpoo7Ow1t2/HBu2NeJJoVTocyD4p6GQU4oIITF+
xJUxNRG6sBAAWKXcvSUeK1RWA7yVhnFSZkz1Iz4mmABsLvCvZqsZO/qtPCPheeZP
BV3nL7RAmXwtScHmCS7t+Cn7OS9mOubevYwnN7VB1NUK9d6Y52r5TwzshI7g+DIa
bTcbQqg2BlfJeR1FV3vZkDDMQ64PFARfpZmuSgTxleVIEm57vzCrnrjI0LUCgjQp
bCCr6V64sGoDzONBtO4F
=gLRV
-----END PGP SIGNATURE-----



References