kicad-developers team mailing list archive
Mailing list archive
Re: [PATCH] wxWidgets 2.8 under Graphics Abstraction Layer Lib (GAL)
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
Dick Hollenbeck <dick@xxxxxxxxxxx>
Mon, 03 Jan 2011 17:50:48 -0600
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:18.104.22.168) Gecko/20101208 Thunderbird/3.1.7
>> I am not a fan of BOOST_FOREACH. Some in this team are, I am not. It does
>> not provide enough value for the costs:
>> 1) obscurity about what code it is actually generating.
>> 2) longer compile times.
>> Suggest simply writing the 3 statements that the macro is replacing, so we
>> see what the compiler sees.
> The Eclipse CDT formatter has also a lot trouble with it. Good suggestion.
Another benefit there is I think you can then remove the findboost from the
I did a grep and it is the only boost dependency you have. (boost is fine,
but asking the user to tell you where it is comes at a cost to the user.
The benefit is not there for this.)