kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

>> 2)))))))))))))))))
>>
>> I am not a fan of BOOST_FOREACH.  Some in this team are, I am not. It does
>> not provide enough value for the costs:
>>
>> 1) obscurity about what code it is actually generating.
>>
>> 2) longer compile times.
>>
>> Suggest simply writing the 3 statements that the macro is replacing, so we
>> see what the compiler sees.
> The Eclipse CDT formatter has also a lot trouble with it. Good suggestion.

Another benefit there is I think you can then remove the findboost from the
CMakeLists.txt file.

I did a grep and it is the only boost dependency you have.  (boost is fine,
but asking the user to tell you where it is comes at a cost to the user. 
The benefit is not there for this.)

Dick