← Back to team overview

kicad-developers team mailing list archive

Re: Make USE_WX_ZOOM=ON the default.


On 1/11/2011 2:18 PM, jean-pierre charras wrote:
> Le 11/01/2011 19:34, Wayne Stambaugh a écrit :
>> I have been playing around with USE_WX_ZOOM=ON again because I've yet again run
>> up against my second least favorite global variable ActiveScreen.  It seems to
>> work fine on both Linux and Windows for displaying, printing, and plotting.
>> Has anyone using OSX tested this?  If there are no technical reasons not to use
>> it, I would like to make this the default setting to flesh out any corner case
>> behavior.  After any issues have been resolved, I would like to eliminate all
>> of the #ifdef USE_WX_ZOOM/#endif code and all of the dead code associated with
>> ActiveScreen.  This has the following advantages:
>> * Gets rid of global variable ActiveScreen.
>> * Eliminate redundant scaling functions.
>> * Remove a layer of drawing code complexity.
>> * Makes me happy :)
>> Any one have any objections?
>> Wayne
> No objection for me.
> Besides, last release candidates are built with USE_WX_ZOOM=ON

I was not aware of that.  I'll make the change to CMakeList.txt in my next
commit.  If there are no bugs reported against the drawing code in the next
couple of weeks, I will remove the unused code.