← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Saving plot dialog settings


On 01/28/2011 11:18 AM, Marco Mattila wrote:
> On Fri, Jan 28, 2011 at 12:21 AM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
>> Any "complex" string that is capable of having either whitespace or quotes
>> in it should be wrapped using
>> aFormatter->Quoted( CONV_TO_UTF8(blah) ).c_str(),
> I'm working on this now. Should there be something like
> if( strchr( quote_char, *wrapee ) )
>       return quote_char;


I just now committed a fix.

I looked at your suggestion, but took a slightly more conservative approach,
since I wanted no part of breaking the specctra export code.  We use a
slightly different quoting protocol over there, since that area cannot be as
well defined as our stuff, nor is it as well documented.  Then you have
Alfon's interpretation blended into whatever you might find in the DSN
spec.  So that is not solid footing, and unnecessary changes are evil. There
is no notion of double quoting in the DSN format, that is all stuff I added
on top of the s-expression stuff, our so called "quoting protocol", which in
essence, is DEFINED by OUTPUTFORMATTER::Quoted().

So that explains why the function Quoted() is not being used over there, in
any specctra export code.

The quoting protocol is our own, and WE should use Quoted() moving forward. 
And if you wonder where our documentation is, you have been reading it
recently, in the source code and in our emails.  Source code is actually a
very accurate form of documentation, albeit not universally understood.

Thanks for your patience and fine work.