← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] new hotkeys window + some menu entry mistakes corrected + CONTRIBUTE file added

 

Le 04/09/2011 13:32, fabrizio a écrit :
jean-pierre,
in attachment you can find the patch for the kicad version I got one
hour ago with:
bzr branch lp:kicad kicad_ft

this is what it changes:

$ bzr status
added:
   CONTRIBUTE.txt
modified:
   common/confirm.cpp
   common/hotkeys_basic.cpp
   eeschema/hotkeys.cpp
   eeschema/menubar.cpp
   gerbview/hotkeys.cpp
   include/confirm.h
   pcbnew/hotkeys.cpp


Let me know if you have any problem

Regards
Fabrizio



The patch is now usable.
I tested it.

In menus, (as expected unfortunately), changing <X> to /tX (i.e. changing hotkey to accelerator menu) does not work:
Hotkeys does not work anymore.
i.e. for J (add junction), the Junction tool is selected, but J does not add a junction
(I must say it is not the first time contributors try to change the ugly <X> message, but this always break hotkeys)


Using a wxHtmlWindow to show current hotkey list is a very good idea.
(I can commit a patch relative to this last enhancement, if you do it)

--
Jean-Pierre CHARRAS



Follow ups

References