kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

On 03/01/2012 09:29 AM, Alexander Zakamaldin wrote:
> === modified file 'common/basicframe.cpp'
> --- common/basicframe.cpp	2012-02-17 14:17:50 +0000
> +++ common/basicframe.cpp	2012-03-01 15:17:12 +0000
> @@ -341,7 +341,7 @@
>  
>          if( !helpFile )
>          {   // Try to find "Getting_Started_in_KiCad.pdf"
> -            wxGetApp().GetHelpFileName() = wxT( "Getting_Started_in_KiCad.pdf" );
> +            wxGetApp().SetHelpFileName( wxT( "Getting_Started_in_KiCad.pdf" ) );
>              helpFile = wxGetApp().GetHelpFile();
>          }


The original problem would have not come about if the return value of the
GetHelpFileName() was

const wxString

instead of

wxString

The compiler could have caught the problem then.  I also like const wxString because it
lets you alternate into

const wxString&

without issue out in client land as well.

Thanks for the fix.