kicad-developers team mailing list archive

[Alexander Zakamaldin <zaka62@xxxxxxx>]

Hi Dick!

The "const" specification is really useful feature, especially for those who clearly
understands what does it stands for.
By the way, please answer Frank bennett, especially to his question about Kicad
developers list and about contributors wishes.

Alexander.


02 марта 2012, 01:12 от Dick Hollenbeck <dick@xxxxxxxxxxx>:
> On 03/01/2012 09:29 AM, Alexander Zakamaldin wrote:
> > === modified file 'common/basicframe.cpp'
> > --- common/basicframe.cpp	2012-02-17 14:17:50 +0000
> > +++ common/basicframe.cpp	2012-03-01 15:17:12 +0000
> > @@ -341,7 +341,7 @@
> >
> >          if( !helpFile )
> >          {   // Try to find "Getting_Started_in_KiCad.pdf"
> > -            wxGetApp().GetHelpFileName() = wxT( "Getting_Started_in_KiCad.pdf" );
> > +            wxGetApp().SetHelpFileName( wxT( "Getting_Started_in_KiCad.pdf" ) );
> >              helpFile = wxGetApp().GetHelpFile();
> >          }
> 
> The original problem would have not come about if the return value of the
> GetHelpFileName() was
> 
> const wxString
> 
> instead of
> 
> wxString
> 
> The compiler could have caught the problem then.  I also like const wxString because it
> lets you alternate into
> 
> const wxString&
> 
> without issue out in client land as well.
> 
> Thanks for the fix.
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>