← Back to team overview

kicad-developers team mailing list archive

Re: I retract my idiotic assertion

 

On 14 May 2012 16:20, jean-pierre charras <jp.charras@xxxxxxxxxx> wrote:
> Le 14/05/2012 15:18, Lorenzo Marcantonio a écrit :
>>
>> On Mon, May 14, 2012 at 02:00:06PM +0200, jp.charras wrote:
>>>
>>> Sorry, I could missed something, but where wires and bus entries have
>>> their thickness every time clamped ?
>>
>>
>> int SCH_LINE::GetPenSize() const
>> {
>>     int pensize = ( m_width == 0 ) ? g_DrawDefaultLineThickness : m_width;
>>
>>     if( m_Layer == LAYER_BUS&&  m_width == 0 )
>>
>>     {
>>         pensize = KiROUND( g_DrawDefaultLineThickness * BUS_WIDTH_EXPAND
>> );
>>         pensize = MAX( pensize, 3 ); //<<<  HERE XD
>>     }
>>
>>     return pensize;
>> }
>>
>> This is maybe to ensure that buses are anyway at least 3 mils wide?
>> It has no sense to me...
>>
>
> Seems to be a bit of old legacy code.
> Keep g_DrawDefaultLineThickness > 0 is better.
>
> --
> Jean-Pierre CHARRAS

I will sort that out in the patch, no problem.

Best Regards, Brian.


References