← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Allow comments in Draw command of library entries


On Sun, 2012-06-03 at 17:31 +0200, jean-pierre charras wrote:
> Le 02/06/2012 01:55, rbunch@xxxxxxxxxxxx a écrit :
> > I was having trouble loading many of the libraries found at:
> >
> > http://library.oshec.org/
> >
> > I discovered the problem was that the DRAW command in the latest versions does not allow comments between DRAW and ENDDRAW.  This simple patch will allow those comments.
> Unfortunately, this is only one of issues with oshec libs.
> - Many oshec libraries are broken.
> - they are not free.
> So developer's incentive to fix issues for these libs in very low.

Ok so perhaps mentioning oshec was a bad idea.  Is the patch I submitted
to allow comments in the DRAW command worthwhile on its on?  It seems
that this issue might come up anytime someone writes a script to
generate library files.  I'm not sure if the fact that comments are
disallowed inside a DRAW/ENDDRAW is documented so it seems reasonable to
expect that it would work.  I'm new to this project and just thought it
would be useful to fix some of these oshec libraries as I was trying to
use them and noticed that some of them worked in earlier releases.  If
there is a list of other issues I might try looking at fixing some
others.  Feel free to correct my thinking, as I am new here...

Follow ups