← Back to team overview

kicad-developers team mailing list archive

Re: Patch for hand-modifiable issue date


On 5/22/2013 2:36 PM, Lorenzo Marcantonio wrote:
> On Wed, May 22, 2013 at 06:36:27PM +0200, Lorenzo Marcantonio wrote:
>> On Wed, May 22, 2013 at 06:23:02PM +0200, jp charras wrote:
>>> Try to use the option wxBU_EXACTFIT for the button style.
> Thanks, it worked as desired.
> The patch applies cleanly and compile against 4159


I took a look at this patch and it looks pretty good.  I had to tweak
the border and the proportion settings of some of the controls to get
them to align properly with the rest of the dialog controls.  Also, you
forgot to uncomment the date field in TITLE_BLOCK::Format() so the date
wasn't getting saved in the new pcb file format.  I went ahead and fixed
it so there is no need to submit another patch.  One thing I do want to
suggest is rather than use wxDP_DEFAULT, we might want to consider using
wxDP_DROPDOWN for the wxDatePickerCtrl.  On Windows, wxDP_DEFAULT uses a
spin control to individually set each date field (day, month, year)
which doesn't feel as user friendly to me as the drop down calendar used
on GTK and OSX.  If there are no objections to this, I will go ahead and
make the change and commit this patch.


Follow ups