← Back to team overview

kicad-developers team mailing list archive

Re: New layer ids

 

On Thu, Jul 03, 2014 at 08:04:47AM -0500, Dick Hollenbeck wrote:
> On the other hand, I never did appreciate any of Lorenzo's layer work.  The LAYER_ID was
> an incomplete solution from the day he brought it up.  I voiced an objection at the time,
> yet gave him latitude to make the commit or not.  He chose to make that commit without my
> endorsement.  It cost him.  My only advice to Lorenzo is that a faster way gain respect is

Actually you never accepted the LAYER_NUM enum-based solution since you
preferred using a simple int. I had the full code in my private branch
and thanks to that I even discovered a couple of typing issue. 

So, no, it never was committed. It was meant as a preparatory work for
the next step (when we finally decided *how* layers would be
implemented). I even kept open the option to use an object for the id
(would have be needed if multiset merge were required).

The funny thing is that your implementation is mostly like the one
I suggested last time (except the LSEQ thing which is really interesting
in its own).

And please stop with that want to get paid stuff, it's getting old :P

-- 
Lorenzo Marcantonio
Logos Srl


References