kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

On 9/2/2014 11:29 PM, Moses McKnight wrote:
> I see what you're talking about with the column alignment.  Fixed that.
> 
> The commented lines were where I commented out the original so I could
> easily put it back if needed when testing.  I've removed those now.
> 
> Hopefully this is the final patch.
> 
> I compiled on WinXP and this appears to work fine there.  Config files
> are now created in %APPDATA%\kicad
> For some reason I can't get pcbnew to run in WinXP because of an "Error
> importing the wxPython API!", and (error1402: invalid cursor handle.);
> but I don't think that's related to my patch.
> 
> Thanks,
> Moses

Can someone please test this on OSX to make sure it doesn't cause any
issues before we commit it.  Also, kicad-install.sh calls `make
install_github_fp-lib-table` to install the global fp-lib-table.  I
cannot find the definition of install_github_fp-lib-table in any of the
kicad CMake files.  Where ever this is defined, it will need to be
changed to copy the global fp-lib-table to ~/.config/kicad.

Thanks,

Wayne

> 
> On 09/02/2014 05:09 PM, Nick Østergaard wrote:
>> Minor note on coding style. According to 4.1.2 Column Alignment in the
>> coding style policy, I think that the lines just before +
>> wxConfigBase*   m_config;  should also be aligned accordingly. I know
>> in some files this was not the case before.
>>
>> You aslo added a commented line, is that intentional?
>> +    //m_common_settings = new wxConfig( KICAD_COMMON );
>>
>> also
>> +//#include <wx/config.h>
>>
>> Except for my code formatting comments, I would say that it is nice to
>> see some attention to the placement of fp-lib-table.
>>
>> Nick
>>
>> 2014-09-02 23:06 GMT+02:00 Moses McKnight <moses@xxxxxxxxxxx>:
>>> On 09/02/2014 11:50 AM, Moses McKnight wrote:
>>>>
>>>> On 09/02/2014 11:36 AM, Wayne Stambaugh wrote:
>>>>>
>>>>> On 8/31/2014 8:35 PM, Moses McKnight wrote:
>>>>>>
>>>>>> On 08/31/2014 11:07 AM, jp charras wrote:
>>>>>>>
>>>>>>> Le 31/08/2014 13:59, Moses McKnight a écrit :
>>>>
>>>> <snip>
>>>>>
>>>>> Moses,
>>>>>
>>>>> I don't think it's necessary to copy the old files.  Most of the
>>>>> configuration set up is fairly trivial.  If you've been using KiCad
>>>>> for
>>>>> any length of time, there probably is a lot of cruft in the config
>>>>> files
>>>>> that is no longer used.  If we are going to make this change, I
>>>>> recommend moving fp-lib-table there as well.  Splitting up the KiCad
>>>>> configuration files in multiple places will only confuse users.  I
>>>>> also
>>>>> recommend migrating windows over to config files instead of using the
>>>>> registry.  The global fp-lib-table file is alread in the
>>>>> %APPDATA%/kicad
>>>>> folder on windows.  I'm sure there will be some grumbling but it's
>>>>> much
>>>>> easier for developers have someone send a config file than digging
>>>>> around the windows registry.
>>>>>
>>>>> Wayne
>>>>
>>>>
>>>> Ok, I can add that to my patch and re-send it if you want me to.  I
>>>> haven't
>>>> looked into what it would take to move the fp-lib-table, but I
>>>> should be
>>>> able to
>>>> move the windows config to %APPDATA%/kicad in a few minutes of work.
>>>
>>>
>>> Ok, I've attached another patch against BZR 5112 which puts the
>>> fp-lib-table
>>> in ~/.config/kicad on linux, and should put all the config files in
>>> %APPDATA%/kicad in windows.  This seems to work fine in Linux, and
>>> when my
>>> WinXP vm finally gets kicad compiled I'll test there as well.
>>>
>>> I did not actually use the %APPDATA% environment variable - since the
>>> code
>>> for the fp-lib-table just used
>>> wxStandardPaths::Get().GetUserConfigDir(), I
>>> did likewise.  I also removed the code that checks the environment
>>> variable
>>> XDG_CONFIG_HOME in linux because that variable is not even set on the
>>> Ubuntu
>>> or Linux Mint installs I have.
>>>
>>> Thanks,
>>> Moses
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>