kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 09/13/14 20:26, Maciej Sumiński wrote:
> On 09/11/14 22:23, Lorenzo Marcantonio wrote:
>> On Thu, Sep 11, 2014 at 08:48:44PM +0200, Lorenzo Marcantonio 
>> wrote:
> [snip]
> 
>> Looking for a volunteer expert in that code section to fix that 
>> thing. Otherwise please give more detailed information to do the 
>> job.
> 
>> Have fun (this wasn't...)
> 
> Hi Lorenzo,
> 
> Huge kudos for your findings and detailed report. I will have a
> closer look at the issue. Hopefully it is not as hard as it seems.
> 
> Regards, Orson

With the attached patch, pads have assigned right net codes first and
then they are added to board. Before I commit the changes, does anyone
see any potential problems in the patch?

Regards,
Orson
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJUFJJjAAoJEBRwGu1hpbJ1OHQH/2dKpKVw/qfVHWMBGJr+L0ks
1YkBe/CHHQ94TVzLK0eP+V3sQmh5QRVdBjo5GGL3nImXQn7UCr5ifl/SDk52/tu4
7FApFaNndMel6KJc0M1oFmAm/bj4PBBDrvDCck11X2Mw70XR3KvQoXcssusB5DQU
ylcVQTobM5FR+IVWv4Apag4iIF3fZgueWwtzWohcstqgJbcWMnRe7qAXpaMaOTwj
lsQ4ebwwO/QzZzeXSJwMPAQ3TRML/o8qu9EwzCN5rgiRzpGwcUWQwTA669UKYvEo
GQmDIMloHAzk6Rx2R0ycL3XMx3zT77wmxW/Hehdlcfh3MEqB0DgQdfhM9unwZsE=
=MaGV
-----END PGP SIGNATURE-----

=== modified file 'pcbnew/xchgmod.cpp'
--- pcbnew/xchgmod.cpp	2014-08-24 07:05:07 +0000
+++ pcbnew/xchgmod.cpp	2014-09-13 18:43:56 +0000
@@ -408,6 +408,7 @@
         return false;
     }
 
+    m_parent->Exchange_Module( aModule, newModule, aUndoPickList );
     m_parent->GetBoard()->Add( newModule, ADD_APPEND );
 
     if( aModule == m_currentModule )
@@ -415,8 +416,6 @@
 
     m_WinMessages->AppendText( wxT( " OK\n" ) );
 
-    m_parent->Exchange_Module( aModule, newModule, aUndoPickList );
-
     return true;
 }