← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Rename instances of "module" to "footprint" for consistency

 

On Thu, Oct 30, 2014 at 03:10:04PM +0100, Marco Ciampa wrote:
> On Thu, Oct 30, 2014 at 08:37:35AM -0400, Wayne Stambaugh wrote:
> > Marco,
> > 
> > In the future, please send patches as attachments rather than in-line.
> > It makes it easier for me view and apply them.  My mail client is not a
> > very good diff file viewer.

Patch attached, should be the last.
Please check it, I do not want to rename some python module with python
footprint :-)

With this, _every_ reference to a footprint as a "module" should be removed.
Hope this is will make things clearer...

bye

-- 


Marco Ciampa

I know a joke about UDP, but you might not get it.

+--------------------+
| Linux User  #78271 |
| FSFE fellow   #364 |
+--------------------+

=== modified file 'pcbnew/autorouter/autorout.cpp'
--- pcbnew/autorouter/autorout.cpp	2014-06-24 16:17:18 +0000
+++ pcbnew/autorouter/autorout.cpp	2014-10-31 07:59:38 +0000
@@ -95,7 +95,7 @@
         Module = (MODULE*) GetScreen()->GetCurItem();
         if( (Module == NULL) || (Module->Type() != PCB_MODULE_T) )
         {
-            wxMessageBox( _( "Module not selected" ) );
+            wxMessageBox( _( "Footprint not selected" ) );
             return;
         }
         break;

=== modified file 'pcbnew/autorouter/move_and_route_event_functions.cpp'
--- pcbnew/autorouter/move_and_route_event_functions.cpp	2014-10-06 01:18:24 +0000
+++ pcbnew/autorouter/move_and_route_event_functions.cpp	2014-10-31 07:59:00 +0000
@@ -136,7 +136,7 @@
     case ID_POPUP_PCB_SPREAD_NEW_MODULES:
         if( GetBoard()->m_Modules == NULL )
         {
-            DisplayError( this, _( "No modules found!" ) );
+            DisplayError( this, _( "No footprint found!" ) );
             return;
         }
 

=== modified file 'pcbnew/class_text_mod.cpp'
--- pcbnew/class_text_mod.cpp	2014-10-04 15:15:38 +0000
+++ pcbnew/class_text_mod.cpp	2014-10-31 08:37:56 +0000
@@ -384,7 +384,7 @@
     };
 
     Line = module->GetReference();
-    aList.push_back( MSG_PANEL_ITEM( _( "Module" ), Line, DARKCYAN ) );
+    aList.push_back( MSG_PANEL_ITEM( _( "Footprint" ), Line, DARKCYAN ) );
 
     Line = GetShownText();
     aList.push_back( MSG_PANEL_ITEM( _( "Text" ), Line, BROWN ) );

=== modified file 'pcbnew/dialogs/dialog_netlist.cpp'
--- pcbnew/dialogs/dialog_netlist.cpp	2014-08-24 07:05:07 +0000
+++ pcbnew/dialogs/dialog_netlist.cpp	2014-10-31 08:36:18 +0000
@@ -209,7 +209,7 @@
 {
     if( m_parent->GetBoard()->m_Modules == NULL )
     {
-        DisplayInfoMessage( this, _( "No modules" ) );
+        DisplayInfoMessage( this, _( "No footprints" ) );
         return;
     }
 
@@ -268,7 +268,7 @@
 
     // Search for missing modules on board.
     if( missing.size() == 0 )
-        list << wxT("<p><b>") <<  _( "No missing modules." ) << wxT("</b></p>");
+        list << wxT("<p><b>") <<  _( "No missing footprints." ) << wxT("</b></p>");
     else
     {
         list << wxT("<p><b>") << _( "Missing:" ) << wxT("</b></p>");
@@ -287,7 +287,7 @@
 
     // Search for modules found on board but not in net list.
     if( notInNetlist.size() == 0 )
-        list << wxT( "<p><b>" ) << _( "No extra modules." ) << wxT( "</b></p>" );
+        list << wxT( "<p><b>" ) << _( "No extra footprints." ) << wxT( "</b></p>" );
     else
     {
         list << wxT( "<p><b>" ) << _( "Not in Netlist:" ) << wxT( "</b></p>" );
@@ -319,7 +319,7 @@
              << wxT( "</b></p>" );
     }
 
-    HTML_MESSAGE_BOX dlg( this, _( "Check Modules" ) );
+    HTML_MESSAGE_BOX dlg( this, _( "Check footprints" ) );
     dlg.AddHTML_Text( list );
     dlg.ShowModal();
 }

=== modified file 'pcbnew/exporters/gen_modules_placefile.cpp'
--- pcbnew/exporters/gen_modules_placefile.cpp	2014-10-26 13:59:01 +0000
+++ pcbnew/exporters/gen_modules_placefile.cpp	2014-10-31 08:05:17 +0000
@@ -554,9 +554,9 @@
     wxString msg;
     if( success )
     {
-        msg.Printf( _( "Module report file created:\n'%s'" ),
+        msg.Printf( _( "Footprint report file created:\n'%s'" ),
                     GetChars( fn.GetFullPath() ) );
-        wxMessageBox( msg, _( "Module Report" ), wxICON_INFORMATION );
+        wxMessageBox( msg, _( "Footprint Report" ), wxICON_INFORMATION );
     }
 
     else

=== modified file 'pcbnew/loadcmp.cpp'
--- pcbnew/loadcmp.cpp	2014-10-08 05:50:56 +0000
+++ pcbnew/loadcmp.cpp	2014-10-31 08:03:22 +0000
@@ -415,10 +415,10 @@
     {
         wxArrayString headers;
 
-        headers.Add( _( "Module" ) );
+        headers.Add( _( "Footprint" ) );
         headers.Add( _( "Library" ) );
 
-        msg.Printf( _( "Modules [%d items]" ), (int) rows.size() );
+        msg.Printf( _( "Footprints [%d items]" ), (int) rows.size() );
 
         EDA_LIST_DIALOG dlg( aWindow, msg, headers, rows, oldName, DisplayCmpDoc );
 

=== modified file 'pcbnew/netlist.cpp'
--- pcbnew/netlist.cpp	2014-08-31 16:19:07 +0000
+++ pcbnew/netlist.cpp	2014-10-31 08:03:51 +0000
@@ -148,7 +148,7 @@
 {
     if( GetBoard()->m_Modules == NULL )
     {
-        DisplayError( this, _( "No Modules" ) );
+        DisplayError( this, _( "No footprints" ) );
         return 0;
     }
 

=== modified file 'pcbnew/xchgmod.cpp'
--- pcbnew/xchgmod.cpp	2014-09-15 14:21:48 +0000
+++ pcbnew/xchgmod.cpp	2014-10-31 08:02:40 +0000
@@ -391,7 +391,7 @@
     FPID  oldFootprintFPID = aModule->GetFPID();
 
     // Load module.
-    line.Printf( _( "Change module '%s' (from '%s') to '%s'" ),
+    line.Printf( _( "Change footprint '%s' (from '%s') to '%s'" ),
                  GetChars( aModule->GetReference() ),
                  oldFootprintFPID.Format().c_str(),
                  aNewFootprintFPID.Format().c_str() );
@@ -519,7 +519,7 @@
 
     if( module == NULL )
     {
-        DisplayError( this, _( "No Modules!" ) );
+        DisplayError( this, _( "No footprints!" ) );
         return;
     }
 


Follow ups

References