kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #16190
Re: [PATCH] GAL hotkey event handling causing beeps on OSX
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Mon, 05 Jan 2015 09:15:29 -0500
-
In-reply-to:
<CAGu=xg3oWoa7Zo40VQMMTYLpVqKQvWACJhwWsbE2NA7DtyqmgA@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
This patch doesn't look correct to me. I don't see how it doesn't break
anything else. If the events are not passed up the event handler chain
as noted in the comment, other event handlers cannot respond to them.
Tom or Orson, do you have any input on this?
On 1/5/2015 2:30 AM, Paulo Henrique Silva wrote:
> Dears,
>
> When using OpenGL canvas on OS X (not tested on other platforms) every
> time a hotkey is pressed I get a beep after the desired action is
> completed (For instance, using H to toggle high contrast mode).
>
> Attached patch fix it. Event handling borrowed from regular canvas which
> only pass the event back to the system (.Skip()) when an action was not
> handled.
>
> Not sure about possible side effects on it tough.
>
> Cheers,
>
> -- Paulo Henrique
> -- Curta Circuitos
> -- Brazil
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References