← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH/RFC] Move exactly and duplicate in modedit (now with arrays)

 

On Sat, 2015-01-24 at 01:35 +0000, John Beard wrote:
> On Sat, 2015-01-10 at 02:27 +0000, John Beard wrote:
> > On Fri, 2014-12-05 at 22:02 +0000, John Beard wrote:
> > 
> > The move exact and duplicate tools are now supplemented by an array tool
> > which allows creation of grid, staggered grid and circular arrays of
> > pads, lines or text within modedit. It is available in both legacy and
> > GAL modes, but blocks can only be handled in the GAL mode. As a teaser,
> > here is a staggered grid array with 100 pads:
> > 
> > http://s11.postimg.org/7xn9q458z/Screenshot_from_2015_01_10_02_14_11.png
> 
> I'd be happy to write up the tools in the docs, but I don't know where
> that should go right now? Wait for a decision about doc formats?
> 
> I believe these tools are ready for inclusion, but I still welcome
> comments, bug reports, advice or requests for changes.
> 
Is there anything else I can do on this branch? There are couple of
stylistic changes (mostly function and parameter naming) that I could
do, and maybe some input validation feedback, but I'm wary of making
this branch any more messy that it already is.

Does anyone know how to reset the Launchpad branch[1] to a sensible branch
point? As far as I can tell, the r5385 is shared between "product" and
"moveexact", but it seems to think everything back to r5313 is in the
merge request, and there are a load of conflicts in files I have never
touched. I don't really want to make a new request, as last time it blew
away comments and all!

Also, for these branches, are many merges preferred to rebasing on top
of the current "product"? It seems rebasing doesn't play well though
git-bzr-ng, but the end result is a more linear history in the branch,
rather than dozens of intermediate "checkpoint" commits that are not
relevant when the branch is merged.

All input welcomed! Code review doubly so!

Thanks,

John

> 
> [1]https://code.launchpad.net/~john-j-beard/kicad/moveexact/+merge/243870
> 






References