kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 28/03/2015 01:07, Mário Luzeiro a écrit :
> Hi Jean-Pierre,
> 
> Here is my updates as you suggested.
> I make an overall pass with some improvements in the documentation and coding style. Still some missing, let me know if still something really needs attention.
> 
> Additional, some improvements more in this patch:
> + fix a bounding box calculation issue.
> + VRML2 parser: add capability to keywords Def Group and USE (should support now VRML2 files converted from FreeCad)
> 
> Sorry for this big patch, some additions are very related with other so lots of things was rewritten..
> I believe also some more tests are still need and maybe some issues may appear with the use.
> 
> Hope you can merge it, thanks!
> 
> Regards,
> Mario Luzeiro

Thanks, Mario.

I committed your patch, with very minor, but needed, fixes:
- fgetc returns an int, not a char (EOF needs int to be accurately tested).
- two copy/paste issues.


-- 
Jean-Pierre CHARRAS