kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I've commented on this before.  It breaks zoom and pan behavior on
windows and linux so it cannot be committed until it is fixed.  I don't
have an issue with providing nightly osx builds for users to test but I
would tread carefully here.  It seems that some osx users are using
alternate pointing devices with success so while you may fix one users
problem you may create a problem for another user.  If you choose to
create nightly builds with this patch, please make sure you label the
build as such so users can choose accordingly.

I don't understand the difficultly in modifying the patch to either be a
build time option or a run time option.  How hard would it be to use
something like wxPlatform to check if osx is the platform and a user
option to enable/disable the osx gesture support.  Something like:

if( (wxPlatform::Get().GetOperatingSystemId() & wxOS_MAC)
  && enableOSXGestures )
{
    perform OSX gesture specific behavior
}
else
{
    perform the existing behavior
}

If speed is an issue, you can keep the wxOperatingSystemId in memory
rather than checking it every time.

On 4/2/2015 9:34 AM, Adam Wolf wrote:
> I don't want to make that choice.  I will leave that up to Wayne.
> 
> I will support making builds of whatever he chooses.
> 
> Adam Wolf
> 
> On Apr 2, 2015 9:31 AM, "Tomasz Wlostowski" <tomasz.wlostowski@xxxxxxx
> <mailto:tomasz.wlostowski@xxxxxxx>> wrote:
> 
>     On 02.04.2015 11:01, Bernhard Stegmaier wrote:
>     > For me, this is still the reason why KiCad without Garths panning
>     patches is just a no-go on OSX.
>     Adam, Wayne,
> 
>     I guess there's no problem with merging these patches to the Mac stable
>     release, especially since we need to build a patched wxWidgets version
>     anyway?
> 
>     Cheers,
>     Tom
> 
>