kicad-developers team mailing list archive

[Henner Zeller <h.zeller@xxxxxxx>]

On 22 June 2015 at 11:25, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>
> On 6/22/2015 1:05 PM, Henner Zeller wrote:
>> On 22 June 2015 at 09:39, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>> Henner,
>>>
>>> This patch fails to apply cleanly against your
>>> better-annotation-dialog-checkbox-messaging.diff patch.
>>
>> I think it conflicted with the "library rescue improvements" patch as
>> there were changes in the vicinity.
>>
>> Updated the patch. Can you try again ?
>>   https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff
>>
>> -h
>
> One small fix I would like to see on this patch is to hide the user
> message text control without the dead space at the top of the dialog
> box.  I believe if you put the static text control in it's own sizer,
> you can hide the sizer and the spacing will take care of itself.  Maybe
> you can just hide the static text control.  You may have to call one of
> the wxWindows fit functions to get this work properly but it would make
> for a nicer looking dialog.

Just hiding did the trick. Updated patch on
  https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff


>
>>
>>> Wayne
>>>
>>> On 6/20/2015 6:57 PM, Henner Zeller wrote:
>>>> Hi,
>>>> When writing a NET file, eeschema notices if not everything is
>>>> annotated, so sends the user to annotate the schematic.
>>>>
>>>> However, it does so by asking this question in a modal dialog box
>>>> first, and _then_ opens the annotation dialog, which is quite some
>>>> annoying sequence.
>>>> In particular if you go through it many times a day :)
>>>>
>>>> So I removed that superfluous message box, but instead added the
>>>> message to the annotation dialog in that case. The user still can
>>>> cancel there if they want.
>>>>
>>>> (See also my 'Possibly low-hanging fruit usability improvement' mail today)
>>>>
>>>> Patch is here:
>>>>
>>>> https://github.com/hzeller/kicad/compare/remove-unnecessary-intermediate-step.diff
>>>>
>>>> Suggested commit message
>>>> -------
>>>> Remove one unnecessary step in the workflow 'exporting NET file
>>>> that requires annotation first'.
>>>> -------
>>>>
>>>> -h
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Attachment: annotate-before.png
Description: PNG image

Attachment: annotate-after.png
Description: PNG image