kicad-developers team mailing list archive

[Ian Roth <imr2107@xxxxxxxxxxxx>]

Thanks, I really hope this can get into the stable release. It is the only
thing holding us back from using kicad at the company I work at.

Ian
On Aug 8, 2015 7:09 PM, "Adam Wolf" <adamwolf@xxxxxxxxxxxxxxxxxxxx> wrote:

> I think this is very good.
>
> Adam Wolf
> On Aug 8, 2015 5:37 PM, "Ian Roth" <imr2107@xxxxxxxxxxxx> wrote:
>
>> This allows users to host the footprint libraries on a local gitlab
>> server in case there is no access to github.
>>
>> I know this patch has the potential to be controversial because the code
>> in the plugin is supposed to be as generic as possible and that the server
>> should change. I would like to counter that by noting that gitlab is
>> probably the most popular option for self hosted git servers, and the code
>> change adds just one string comparison and a string concatenation to make
>> the integration work.
>>
>> This patch can be found online at:
>> https://github.com/KiCad/kicad-source-mirror/pull/6/files
>>
>> Git diff:
>> diff --git a/pcbnew/github/github_plugin.cpp
>> b/pcbnew/github/github_plugin.cpp
>> index 695365c..8ab03a2 100644
>> --- a/pcbnew/github/github_plugin.cpp
>> +++ b/pcbnew/github/github_plugin.cpp
>> @@ -516,6 +516,14 @@ bool GITHUB_PLUGIN::repoURL_zipURL( const wxString&
>> aRepoURL, string* aZipURL )
>>
>>              zip_url += repo.GetPath();      // path comes with a leading
>> '/'
>>
>> +            // This is intented for use with gitlab, for users who wish
>> to self-host
>> +            // the library repos on a local server. The KIGITHUB path
>> (and thus server name)
>> +            // must contain "git" for this code to work.
>> +            if ( repo.GetServer().Contains("git") )
>> +            {
>> +                zip_url += "/repository/archive.zip";
>> +            }
>> +
>>              // Do not modify the path, we cannot anticipate the needs of
>> all
>>              // servers which are serving up zip files directly.  URL
>> modifications
>>              // are more generally done in the server, rather than
>> contaminating
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>