kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

David,

How did you generate your patch file?  I doesn't look like a unified
diff format to me.  The easiest way to generate a unified diff is use
Bazaar or git to create a development branch on your system, make your
changes, then generate you diff by running bzr diff or git diff.  Also,
please read the KiCad coding policy, you used tabs instead of spaces for
indenting, I see a bunch of trailing white space left behind by your
editor, and the preferred maximum line length is 100 characters.

Cheers,

Wayne


On 8/11/2015 9:39 AM, David Novak wrote:
> We were required to make the following changes to the GenCAD exporter
> after our contract manufacturer rejected the exported GenCAD file.
> 
>   * Don't make new shape for every reference designator. Instead, create
>     shapes based on modules and assign to devices based on reference
>     designators.
>   * Don't allow pins without numbers to have duplicate pin numbers.
>   * Correctly implement MIRRORX.
>   * Correctly implement flip.
> 
> I've attached the only file that was modified. Additionally, I've
> attached a patch file.
> 
> Best Regards,
> David
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>