← Back to team overview

kicad-developers team mailing list archive

Re: Eeschema ERC should detect unmatched local labels

 

Hi @JP,

Have you got a chance to review this submitted patch?

--JC

On 09/14/2015 10:58 PM, Joseph Chen wrote:
@JP,

Attached you can find the patch file for the improvement of optional ERC's detecting local labels.

Short description:
With this patch, there is an added extra check box inside ERC pop-up window, which by default is "un-checked".

This extra check box has a name "Check Unmatched Labels". When it is "un-checked", ERC's "Run" will just function as normal as it used to be, so to avoid un-wanted noises for some people who don't bother detecting; when it is "checked", ERC's "Run" will detect the "unmatched" local labels.


I also attached a new test schematic tar ball that can be used for testing the patch functions.

Thank you for all your valuable comments and insights.

I would appreciate anyone could test this patch out and provide comments and inputs.

--JC

On 09/14/2015 03:30 AM, jp charras wrote:
Le 14/09/2015 06:17, Joseph Chen a écrit :
@Wayne and @JP,

Could try ERC on this simple schematic file?

Attached, you can find a test schematic file that has an unintended
unmatched local labels, and current kicad ERC does not detect them.

In the test schematic file, there is a mis-spelled local label on the
right hand side.  The local labels are constructed with an intention of
using them to serve as ratnets, not just a convenient text.
With this kind of mis-detected errors, the PCB will not have the
intended ratnet at all and thus no copper track will be laid out, and
thus the manufactured boards will be bad.

--Joe

The test schematic looks good for a reader.
You said:
"The local labels are constructed with an intention of using them to
serve as ratnets, not just a convenient text"
But only the designer (you) knows that.

Detecting mis-spelled local labels is not so easy, if you want to avoid
noise. And if there is noise, this feature is useless.
Many designers widely use a local label (and only one) to name a net for
many reasons.
This is not necessary a design error (in fact 99% of cases are not an error)

Having said that, I think you could send us a patch, at least to try
this feature, and see how useful it is in many different designs, and
perhaps improve it to avoid noise.

But keep in mind testing a patch and include it in a stable release are
not the same thing.





Follow ups

References