← Back to team overview

kicad-developers team mailing list archive

Re: [rfc patch] replace avhttp with libcurl

 

2015-12-04 14:15 GMT+01:00 Mark Roszko <mark.roszko@xxxxxxxxx>:
>>I understand what you mean, but I am pretty sure avhttp did not test
> certificates.
> It did using boost::asio:ssl which has the functionality for it.
>
> in include/avhttp/impl/http_stream.ipp you can even see the
> m_check_certificate option which kicad never turned off.
>
>
>>I am worried by the fact most of Kicad users know nothing about
>>certificates, and using them is open a door to a lot of bug reports (the
>>fp lib table issues could be zilch compared to that).
>
> We would bundle it with the kicad  for Windows and it should be fine.
> Anyone else should have a dependency on their installed kicad package
> on libcurl which in term will have a dependency on ca-certificates.
>
>
>>I am thinking the certificate ca-bundle.crt is OK (cURL works fine since
>>I updated it), but it is just not found by Kicad (It could be fixed).
>
> On two of my machines inside MSYS2, curl works just fine in kicad :/
>
>
>>I am thinking the certificate ca-bundle.crt is OK (cURL works fine since I updated it), but it is just not found by Kicad (It could be fixed).
>
> It can be by setting the paths within kicad. But its more of a MSYS2 issue.

I am not exactly sure why it happens, but this happens on msys2 when
you do not upgrade "properly". If you blindly pacman -Syu when it will
update the mingw something something dll, which requires you to only
update that and close the shell and reopen to continue the update this
ca-certificates thing happen where https do not work.  But if you do
update-repo and then pacman -Sy   to update it should be good at all
times -- apparently.

> Interesting is they compile with
> _variant_config+=("--with-ca-bundle=${MINGW_PREFIX}/ssl/certs/ca-bundle.crt")
>
> so I have it in
> D:\msys64\usr\ssl\certs
> and
> D:\msys64\mingw64\ssl\certs
>
> They do add a patch to curl that makes the ca-bundle path relative to
> the executable.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References