kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #21695
Re: [patch] default kicad_common to environment variables
I think that would be a good idea. This is the way it seems to always go
for me too--have a patch to add something to KiCad, and expose an issue we
didn't realize we had :)
Adam Wolf
On Mon, Dec 7, 2015 at 12:10 PM, Mark Roszko <mark.roszko@xxxxxxxxx> wrote:
> wxFileName makes some "choices". i.e. its constructor/assignment takes
> the string and tries to separate file from path.
>
> in the case of wxFileName = "helloworld"; it assumes its a filename
> in the case of wxFileName = "/helloworld", it assumes its a file name
> in the case of wxFilename = "helloworld/"; it assumes its a folder
>
> and of course AppendDir adds a directory the path and because filename
> is separate from directory, the end behavior is what you say. (i.e.
> directory gets concatted before file)
>
>
> The proper solution to fix this would be to GetPathSeparator() and
> append it to the environment variable string after reading but before
> assigning it to the tmpFileName, thus creating
> double slashes in the worst case but wxFileName should clean that out.
> I'll add it to the patch later tonight if need be.
>
Follow ups
References
-
[patch] default kicad_common to environment variables
From: Mark Roszko, 2015-12-04
-
Re: [patch] default kicad_common to environment variables
From: Nick Østergaard, 2015-12-04
-
Re: [patch] default kicad_common to environment variables
From: Adam Wolf, 2015-12-04
-
Re: [patch] default kicad_common to environment variables
From: Mark Roszko, 2015-12-04
-
Re: [patch] default kicad_common to environment variables
From: Wayne Stambaugh, 2015-12-04
-
Re: [patch] default kicad_common to environment variables
From: Nick Østergaard, 2015-12-06
-
Re: [patch] default kicad_common to environment variables
From: Adam Wolf, 2015-12-06
-
Re: [patch] default kicad_common to environment variables
From: Wayne Stambaugh, 2015-12-06
-
Re: [patch] default kicad_common to environment variables
From: Adam Wolf, 2015-12-07
-
Re: [patch] default kicad_common to environment variables
From: Wayne Stambaugh, 2015-12-07
-
Re: [patch] default kicad_common to environment variables
From: Adam Wolf, 2015-12-07
-
Re: [patch] default kicad_common to environment variables
From: Adam Wolf, 2015-12-07
-
Re: [patch] default kicad_common to environment variables
From: Adam Wolf, 2015-12-07
-
Re: [patch] default kicad_common to environment variables
From: Nick Østergaard, 2015-12-07
-
Re: [patch] default kicad_common to environment variables
From: Wayne Stambaugh, 2015-12-07
-
Re: [patch] default kicad_common to environment variables
From: Adam Wolf, 2015-12-07
-
Re: [patch] default kicad_common to environment variables
From: Mark Roszko, 2015-12-07