kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

2015-12-07 19:45 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> I'm not sure what you mean by it did not work at all.  It does exactly
> what I designed to do.  It gives the user the ability to override the
> env variables by doing this:
>
> export KISYSMOD=/some/path/to/footprint/libraries
> kicad

But in this case (without the patch) this will not make the
KISYSMOD=/some/path/to/footprint/libraries on a fresh installation
(config not present or deleted). And this was the sole issue, in my
view. I hope you see what I mean.

> and to gives package devs a way to define where the library and template
> files are installed in a given package by defining DEFAULT_INSTALL_PATH.
>  The only error I can see is that if you do `export KISYSMOD=""` to
> undefined the env variable, I didn't check for an empty value so it will
> be empty in the fp-lib-table.  I probably should have also made sure the
> path actually exists before I assign it.  I just retested this to make
> sure it works as I intended to and it does.
>
> Mark's patch is a different solution to the DEFAULT_INSTALL_PATH problem
> which is as easily broken as my solution.  Don't believe me, try this.
> Install the library files in some path that is not in the correct path
> relative to the kicad bin path.  The default env variables will once
> again be wrong.  There is no perfect solution for this problem.

Yes, I understand, I would just like it to at least work in the most
common scenario. And that is when the windows user installs on his own
computer and user.

> Even if
> you added a solution to the installer package, it would only work for
> the user that installed the package.  The next user on the system would
> be at the mercy of the default install path issue.  Mark's solution only
> helps windows users when they change their default install path.  If our
> package devs are not configuring DEFAULT_INSTALL_PATH, then that is an
> issue.  I'm pretty sure I made an announcement on the developers mailing
> list that you would need to set this if your CMAKE_INSTALL_PREFIX was
> set to a temporary path for packaging purposes.  If I didn't, then my bad.

You did inform us something about the DEFAULT_INSTALL_PATH at an
earlier time when it was implemented. But this do not really help us
in the situation with the windows installer, where we allow the
enduser to install to an abritrary location.

So I want to use the env vars to runtime (when the installer runs) set
the path used for the installation, such that the libs will be found
for the vast majority of the users installing KiCad on windows.

> On 12/7/2015 1:05 PM, Nick Østergaard wrote:
>> That it did not work at all.
>>
>> 2015-12-07 18:55 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>>> Was this the case before the patch?  I don't remember seeing this when I
>>> was debugging the original code.
>>>
>>> On 12/7/2015 12:15 PM, Nick Østergaard wrote:
>>>> Yes, I noticed that too. :)
>>>>
>>>> 2015-12-07 18:14 GMT+01:00 Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>:
>>>>> To clarify, by "results", I mean "shows up in the path manager as".  I
>>>>> wonder if we're doing something later, hmm.
>>>>>
>>>>> Adam Wolf
>>>>>
>>>>> On Mon, Dec 7, 2015 at 11:09 AM, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>
>>>>> wrote:
>>>>>>
>>>>>> It works fine on OS X.
>>>>>>
>>>>>> I found a weirdess with AppendDir, however, that I don't think should hold
>>>>>> this patch up, but I want to mention on the list.
>>>>>>
>>>>>> If tmpfilename is set to something like "helloworld",
>>>>>>
>>>>>>             tmpFileName.AppendDir( wxT( "packages3d" ) );
>>>>>>
>>>>>> results in "packages3d/helloworld", which is not what I expected.  If you
>>>>>> add slashes, however, and set  tmpFileName to "/helloworld/",
>>>>>>
>>>>>>             tmpFileName.AppendDir( wxT( "packages3d" ) );
>>>>>>
>>>>>> results in "/helloworld/packages3d".
>>>>>>
>>>>>> *sigh*
>>>>>>
>>>>>> Adam Wolf
>>>>>>
>>>>>>
>>>>>> On Mon, Dec 7, 2015 at 9:36 AM, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>
>>>>>> wrote:
>>>>>>>
>>>>>>> The test build is going now, will be done within 30 minutes.
>>>>>>>
>>>>>>> Adam Wolf
>>>>>>>
>>>>>>> On Mon, Dec 7, 2015 at 9:31 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>> Adam,
>>>>>>>>
>>>>>>>> I forgot to ask, do you want me to go ahead with this patch?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Wayne
>>>>>>>>
>>>>>>>> On 12/6/2015 7:13 PM, Adam Wolf wrote:
>>>>>>>>> When are you planning on doing the 4.0.1 release? Todayish or in about
>>>>>>>>> 7
>>>>>>>>> days?
>>>>>>>>>
>>>>>>>>> Adam Wolf
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Dec 6, 2015, 5:41 PM Wayne Stambaugh <stambaughw@xxxxxxxxx
>>>>>>>>> <mailto:stambaughw@xxxxxxxxx>> wrote:
>>>>>>>>>
>>>>>>>>>     On 12/6/2015 3:52 PM, Adam Wolf wrote:
>>>>>>>>>     > If it would help the installer, would it help if we ifdef OSX
>>>>>>>>> out,
>>>>>>>>>     and I
>>>>>>>>>     > test on OS X next week and we remove the ifdef?
>>>>>>>>>     >
>>>>>>>>>     > I am also relatively comfortable applying this on OS X without
>>>>>>>>> testing
>>>>>>>>>     > it.  I have been neck deep in that code over the last few weeks
>>>>>>>>>     because
>>>>>>>>>     > of the 3D modules work I was doing for OS X in prep for 4.0.0
>>>>>>>>> and it
>>>>>>>>>     > looks OK to me.
>>>>>>>>>
>>>>>>>>>     If your comfortable with it, I will commit it to the product
>>>>>>>>> branch and
>>>>>>>>>     merge it into the 4.0 branch for the 4.0.1 release.  Let me know
>>>>>>>>> if
>>>>>>>>>     that's what you want me to do.  This is one of the rare exceptions
>>>>>>>>> I
>>>>>>>>>     will make as far as back porting non-critical bugs.
>>>>>>>>>
>>>>>>>>>     >
>>>>>>>>>     > Either way, I know I can test this early this week.
>>>>>>>>>     >
>>>>>>>>>     > Adam Wolf
>>>>>>>>>     >
>>>>>>>>>     > On Sun, Dec 6, 2015 at 2:48 PM, Nick Østergaard
>>>>>>>>> <oe.nick@xxxxxxxxx
>>>>>>>>>     <mailto:oe.nick@xxxxxxxxx>
>>>>>>>>>     > <mailto:oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>>> wrote:
>>>>>>>>>     >
>>>>>>>>>     >     I am very tempted to just apply this to the 4.0.0 windows
>>>>>>>>>     installer,
>>>>>>>>>     >     just such that the libs will actually work when people
>>>>>>>>> install
>>>>>>>>>     them.
>>>>>>>>>     >
>>>>>>>>>     >     Should I refrain from this?
>>>>>>>>>     >
>>>>>>>>>     >     I have tested the patch on windows and linux. It works as
>>>>>>>>>     expected.
>>>>>>>>>     >
>>>>>>>>>     >     2015-12-04 15:21 GMT+01:00 Wayne Stambaugh
>>>>>>>>>     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>>>>>>>>>     >     <mailto:stambaughw@xxxxxxxxx
>>>>>>>>> <mailto:stambaughw@xxxxxxxxx>>>:
>>>>>>>>>     >     > Obviously this patch is only going to be useful for the
>>>>>>>>>     first time
>>>>>>>>>     >     kicad
>>>>>>>>>     >     > is run.  Existing installs will change.  I'm fine with
>>>>>>>>>     applying it
>>>>>>>>>     >     once
>>>>>>>>>     >     > it has been tested on OSX and Linux.  I'm at my bandwidth
>>>>>>>>>     limit so I'm
>>>>>>>>>     >     > going to need some help with the testing.
>>>>>>>>>     >     >
>>>>>>>>>     >     > On 12/4/2015 9:08 AM, Mark Roszko wrote:
>>>>>>>>>     >     >> 1. Users can install anywhere
>>>>>>>>>     >     >> 2. x86 vs x64
>>>>>>>>>     >     >>
>>>>>>>>>     >     >> 32-bit on XP => Program Files
>>>>>>>>>     >     >> 32-bit on 64-bit => Program Files (x86)
>>>>>>>>>     >     >> 64 on 64-bit => Program Files
>>>>>>>>>     >     >> 64 on the rare 64-bit XP => Program Files (x64)
>>>>>>>>>     >     >>
>>>>>>>>>     >     >> _______________________________________________
>>>>>>>>>     >     >> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>>     >     >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>>>>>>>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>>>>>>>     >     >> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>>     >     >> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>     >     >>
>>>>>>>>>     >     >
>>>>>>>>>     >     >
>>>>>>>>>     >     > _______________________________________________
>>>>>>>>>     >     > Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>>     >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>>>>>>>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>>>>>>>     >     > Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>>     >     > More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>     >
>>>>>>>>>     >     _______________________________________________
>>>>>>>>>     >     Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>>     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>>>>>>>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>>>>>>>>     >     Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>>     >     More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>     >
>>>>>>>>>     >
>>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>