kicad-developers team mailing list archive

[Simon Wells <simonrwells@xxxxxxxxx>]

The main issue hear appears to be the line

check_find_package_result( OPENMP_FOUND "OpenMP" )
which will do a FATAL with a message if it is not found, potentially
the behaviour of this cmake module should change as based on its name
it doesn't sound like it should be for required dependencies, and
therefore FATAL'ing if the module is not found

This line was only added in the patch that was commited into the tree
in BZR-6363 and is presumably being used to populate the OPENMP_FOUND
cmake variable used just below it



> He didn't add it, he just moved it out of the GCC specific
> configuration.  I'm not sure why openmp would only be required when
> using gcc and not other compilers (which technically are not supported).
>  Do we even need openmp?  Where is used in KiCad?  If we do need it, is
> it only required when building kicad with gcc?
> On 12/10/2015 8:26 AM, Nick Østergaard wrote:
> > It was added in the patch by the other Simon.
> >
> > https://github.com/KiCad/kicad-source-mirror/commit/e87258510567cb95800178dec30b058c885c326c#diff-af3b638bc2a3e6c650974192a53c7291
> >
> > 2015-12-10 14:22 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> >> I'm not sure why openmp would be a dependency that is compiler
> >> dependent.  I didn't add the openmp dependency so I cannot comment on
> >> why this would be specific to gcc.  Anyone else know why openmp was gcc
> >> specific?
> >>
> >> On 12/9/2015 7:15 PM, Simon Wells wrote:
> >>> In BZR-6363 a patch was made so that OpenMP worked on non-gcc compilers
> >>>
> >>>
> >>> check_find_package_result( OPENMP_FOUND "OpenMP" )
> >>>
> >>> Was also added, This appears to make OpenMP a dependency for building kicad?
> >>>
> >>> Is this meant to be the case or was this line added in error
> >>>
> >>> thanks
> >>>
> >>> Simon
> >>>
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp


-- 
<a href="www.google.com/">hello</a>