kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Personally I prefer the patches as separate commits like this - I find it
easier to review in small chunks, and easier to give useful feedback if
something is wrong. It's trivial to commit them together anyway (just apply all
of them in sequence with 'patch', or if you use git and git-am just squash the
commits with a rebase).

On Mon, Mar 28, 2016 at 07:55:05PM +0200, jp charras wrote:
> Le 28/03/2016 01:01, Jan Dolezal a écrit :
> > ---
> >  common/dialogs/dialog_hotkeys_editor.cpp |  1 +
> >  common/widgets/widget_hotkey_list.cpp    | 20 ++++++++++++++++++++
> >  include/widgets/widget_hotkey_list.h     |  7 +++++++
> >  3 files changed, 28 insertions(+)
> > 
> 
> Patches inside mails are never easy to apply.
> Please, generate only one patch, and send us as attached file.
> 
> Thanks.
> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp