kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #24929
[PATCH 13/16] Avoid static variable in wire merge
There is little to no reason why this variable should be static, given that
it is cleared after each iteration.
---
eeschema/sch_line.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/eeschema/sch_line.cpp b/eeschema/sch_line.cpp
index 72efb5c..050b786 100644
--- a/eeschema/sch_line.cpp
+++ b/eeschema/sch_line.cpp
@@ -346,8 +346,7 @@ bool SCH_LINE::MergeOverlap( SCH_LINE* aLine )
// for horizontal segments the uppermost and the lowest point
if( colinear )
{
- static std::vector <wxPoint*> candidates;
- candidates.clear();
+ std::vector <wxPoint*> candidates;
candidates.push_back( &m_start );
candidates.push_back( &m_end );
candidates.push_back( &aLine->m_start );
Follow ups
References
-
[PATCH 00/16] Simple patches
From: Simon Richter, 2016-06-07
-
[PATCH 01/16] Fix spelling "propage" -> "propagate"
From: Simon Richter, 2016-06-07
-
[PATCH 02/16] Add missing dependency github_plugin -> pcbcommon
From: Simon Richter, 2016-06-07
-
[PATCH 03/16] Clarify ERC: we're iterating netlist items, not nets
From: Simon Richter, 2016-06-07
-
[PATCH 04/16] Explain how ERC works.
From: Simon Richter, 2016-06-07
-
[PATCH 05/16] Cache netlist item during ERC
From: Simon Richter, 2016-06-07
-
[PATCH 06/16] Check sorting of netlist during ERC
From: Simon Richter, 2016-06-07
-
[PATCH 07/16] Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets
From: Simon Richter, 2016-06-07
-
[PATCH 08/16] Drop extra copy ctors from IFSG_NODE
From: Simon Richter, 2016-06-07
-
[PATCH 09/16] Replace boost::shared_ptr with std::shared_ptr
From: Simon Richter, 2016-06-07
-
[PATCH 10/16] Replace unshared boost::shared_array with std::unique_ptr
From: Simon Richter, 2016-06-07
-
[PATCH 11/16] Clarify ownership semantics
From: Simon Richter, 2016-06-07
-
[PATCH 12/16] Make NETLIST_OBJECT::GetConnectionType() const
From: Simon Richter, 2016-06-07