← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 13/16] Avoid static variable in wire merge

 

This patch and 0014-Reserve-appropriate-space-in-local-vector.patch have
been committed to the product branch r6950.  FYI, U fixed a coding
policy violation.  The line:

candidates.reserve(4);

should read:

candidates.reserve( 4 );

Also, please update the copy right date as needed when modifying source
files.

Thanks,

Wayne

On 6/7/2016 3:54 PM, Simon Richter wrote:
> 
> There is little to no reason why this variable should be static, given that
> it is cleared after each iteration.
> ---
>  eeschema/sch_line.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References