kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #25221
Re: [PATCH 13/16] Avoid static variable in wire merge
This patch and 0014-Reserve-appropriate-space-in-local-vector.patch have
been committed to the product branch r6950. FYI, U fixed a coding
policy violation. The line:
candidates.reserve(4);
should read:
candidates.reserve( 4 );
Also, please update the copy right date as needed when modifying source
files.
Thanks,
Wayne
On 6/7/2016 3:54 PM, Simon Richter wrote:
>
> There is little to no reason why this variable should be static, given that
> it is cleared after each iteration.
> ---
> eeschema/sch_line.cpp | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References
-
[PATCH 00/16] Simple patches
From: Simon Richter, 2016-06-07
-
[PATCH 01/16] Fix spelling "propage" -> "propagate"
From: Simon Richter, 2016-06-07
-
[PATCH 02/16] Add missing dependency github_plugin -> pcbcommon
From: Simon Richter, 2016-06-07
-
[PATCH 03/16] Clarify ERC: we're iterating netlist items, not nets
From: Simon Richter, 2016-06-07
-
[PATCH 04/16] Explain how ERC works.
From: Simon Richter, 2016-06-07
-
[PATCH 05/16] Cache netlist item during ERC
From: Simon Richter, 2016-06-07
-
[PATCH 06/16] Check sorting of netlist during ERC
From: Simon Richter, 2016-06-07
-
[PATCH 07/16] Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets
From: Simon Richter, 2016-06-07
-
[PATCH 08/16] Drop extra copy ctors from IFSG_NODE
From: Simon Richter, 2016-06-07
-
[PATCH 09/16] Replace boost::shared_ptr with std::shared_ptr
From: Simon Richter, 2016-06-07
-
[PATCH 10/16] Replace unshared boost::shared_array with std::unique_ptr
From: Simon Richter, 2016-06-07
-
[PATCH 11/16] Clarify ownership semantics
From: Simon Richter, 2016-06-07
-
[PATCH 12/16] Make NETLIST_OBJECT::GetConnectionType() const
From: Simon Richter, 2016-06-07
-
[PATCH 13/16] Avoid static variable in wire merge
From: Simon Richter, 2016-06-07