← Back to team overview

kicad-developers team mailing list archive

Re: 3D-Viewer - Request for merge evaluation

 

Le 21/06/2016 à 19:07, Mário Luzeiro a écrit :
>> I think there are other tweaks to be made but they can wait. :)
> 

About tweaks, I found 2 minor issues:

1 - your rev 6066 (Do not redraw the 3D viewer after a change in pcbnew) is not good.
 It has side effects: for instance, when changing material options, the 3D board is not redrawn,
giving the impression of an unresponsive command.
I saw the comment:
    // This function is used by moduleframe.cpp
    // while editing the pcb board, so it will not redraw to not slow the pcbnew
But if the user displays the 3D view during an edition, he expects to see the changes
(on my computer, a change in footprint editor takes less than 0.1 sec to be redrawn in the 3D viewer)

2 - A minor other issue:
 in Opengl render, if you click on the thirst icon of the toolbar, you run the raytracing only once.
 This is true if you change the zoo, orientation ... from the mouse.
 But if you rotate the view from the toolbar icons, there is a strange mix of raytracing and opengl
mode, until you change the view from the mouse.


Thanks, Mário, for your hard work.

-- 
Jean-Pierre CHARRAS


Follow ups

References