kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

JP committed a patch (r6980) to the dialog shim class that addresses the
issue.  I would like to get some feedback from the OSX users to see if
it properly resolves the issue.  We already have some positive initial
feedback.  If this resolves the issue, it will need to be merged into
the stable branch because this is a major issue for OSX users.  I would
like to get this in the 4.0.3 release if possible.  JP has already
committed to getting me a patch that merges cleanly into the stable branch.

On 7/14/2016 2:49 PM, Simon Wells wrote:
> Do we really want to patch wx with a patch that from what i understand
> is not due to be merged into the wx code base?
> 
> On Fri, Jul 15, 2016 at 3:42 AM, Bernhard Stegmaier
> <stegmaier@xxxxxxxxxxxxx> wrote:
>> So we are back to the question we already had at the beginning of this
>> thread.
>> Should we workaround this in KiCad or not?
>>
>> There was a pretty small patch for wxWidgets that obviously has the same
>> effect, but it doesn’t garble KiCad source.
>> Probably it is a piece of cake for Adam to apply it to the official builds.
>> Of course, everyone building on its own would have to take care of on their
>> own.
>>
>>
>> Regards,
>> Bernhard
>>
>> On 14 Jul 2016, at 12:31, Brano Panak <bpanak@xxxxxxxxx> wrote:
>>
>> tested with osx and r6976:
>>
>> in pcbnew/dimensions/grid
>>
>> cmd+c copy selected (does not close dialog)
>>
>> enter, esc,  ok, cancel  button works ok
>>
>> cmd+c, cmd+x, cmd+v  works ok
>>
>>
>> On 13/07/16 18:43, jp charras wrote:
>>
>> Le 13/07/2016 à 08:22, jp charras a écrit :
>>
>> Le 13/07/2016 à 02:26, Brano Panak a écrit :
>>
>> as far as i can see in my version yes, this can be specified in
>> wxFormBuilder as separate fields ID
>> and LABEL
>>
>> You cannot specify the label when using a wxStdDialogButtonSizer in
>> wxFormBuilder.
>> Using a wxStdDialogButtonSizer is a good practice, because it uses the look
>> and feel of each
>> platform to display these standard buttons.
>>
>>
>> @Brano,
>> Can you test this patch?
>> (Only the Dimension/grid dialog is patched in Pcbnew)
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>