kicad-developers team mailing list archive

[Clemens Koller <cko@xxxxxxxxx>]

I didn't get any feedback from my last mail yet. Here is a patch to remove 
IMO unnecessary .png files, supplementing my last patch.

Regards,

Clemens

On 2017-01-31 21:00, Clemens Koller wrote:
> Hello!
> 
> Attached is a new patch to cleanup the color code bitmaps in pcb_calculator.
> The k is in lower-case. Some color artefacts are removed frames are cleaned up.
> 
> I've noticed that there are still the old/redundant .png files in
> /pcb_calculator/bitmaps/sources/color_code/*.png
> I guess these can be deleted as GIMP is able to work with .xpm images genericly.
> If not, please let me know how to trigger the .xpm generation and I'll republish the .png files (binary though).
> 
> Regards,
> 
> Clemens
> 
> 
> On 2017-01-31 17:16, Kevin Bortis wrote:
>> On Fri, Jan 27, 2017 at 1:14 PM jp charras <jp.charras@xxxxxxxxxx> wrote:
>>>
>>> Le 27/01/2017 à 13:02, Jean-Noël AVILA a écrit :
>>>> Le 27/01/2017 à 12:50, jp charras a écrit :
>>>>> Le 27/01/2017 à 12:26, Chris Pavlina a écrit :
>>>>>> I noticed the artifacts in the code too, but didn't see anything in the
>>>>>> graphic.
>>>>>>
>>>>>> I would definitely take another update from anyone who wants to further
>>>>>> edit this:
>>>>>>
>>>>>> - Remove any artifacts that may be present
>>>>>> - Use lower-case "k"
>>>>> Interesting topic:
>>>>> In France, unit prefixes corresponding to a scaling factor > 1 are in upper case and < 1 in lower case.
>>>>
>>>> I have no knowledge of such "rule". In France, we are mainly using ISO
>>>> notation.
>>>>
>>>>> This is the "legal" notation, and I am thinking this is an ISO normalization.
>>>>> therefore M is mega and m is milli.
>>>>
>>>> This rule may appear to be true for this case, but it is not a rule (see
>>>> below).
>>>>
>>>>>
>>>>> Although K is kilo (the only one official notation) and k does not exist in "legal" notation,
>>>>
>>>> False! kilo is always k : kg, km, k-ohms and so on.
>>>>
>>>> See https://en.wikipedia.org/wiki/Metric_prefix
>>>>
>>>
>>
>> And overall upper case letter "K" stand for Kelvin in SI notation,
>> even without a ° (° K). See http://www.bipm.org/en/measurement-units/
>> and http://www.bipm.org/en/measurement-units/ as reference.
>>
>> So this should be a lower case "k" to be technical correct.
>>
>>>
>>>
>>> Sorry, you are right, and i am stupid.
>>> I was confusing by M (mega) and m (milli)
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

>From 9fe5973ae1da0a11f57d1a25954f5cffc0700dac Mon Sep 17 00:00:00 2001
From: Clemens Koller <cko@xxxxxxxxx>
Date: Wed, 1 Feb 2017 15:29:48 +0100
Subject: pcb_calculator: delete obsolete sources of binary bitmaps (.pngs)

The bitmaps/*.xpm files can be edited as regular pictures
(i.e. using GIMP), so, bitmaps/sources/color_code/* don't need to be
kept as well.

Signed-off-by: Clemens Koller <cko@xxxxxxxxx>

diff --git a/pcb_calculator/bitmaps/sources/color_code/color_code_multiplier.png b/pcb_calculator/bitmaps/sources/color_code/color_code_multiplier.png
deleted file mode 100644
index b948c4f20..000000000
Binary files a/pcb_calculator/bitmaps/sources/color_code/color_code_multiplier.png and /dev/null differ
diff --git a/pcb_calculator/bitmaps/sources/color_code/color_code_tolerance.png b/pcb_calculator/bitmaps/sources/color_code/color_code_tolerance.png
deleted file mode 100644
index 0ba4c5f90..000000000
Binary files a/pcb_calculator/bitmaps/sources/color_code/color_code_tolerance.png and /dev/null differ
diff --git a/pcb_calculator/bitmaps/sources/color_code/color_code_value.png b/pcb_calculator/bitmaps/sources/color_code/color_code_value.png
deleted file mode 100644
index 1e7dcb2ca..000000000
Binary files a/pcb_calculator/bitmaps/sources/color_code/color_code_value.png and /dev/null differ
diff --git a/pcb_calculator/bitmaps/sources/color_code/color_code_value_and_name.png b/pcb_calculator/bitmaps/sources/color_code/color_code_value_and_name.png
deleted file mode 100644
index d7dedfdcd..000000000
Binary files a/pcb_calculator/bitmaps/sources/color_code/color_code_value_and_name.png and /dev/null differ