kicad-developers team mailing list archive

[John Beard <john.j.beard@xxxxxxxxx>]

Hi,

I have rebased this branch over the new PCB_ACTION changes.

Cheers,

John

On Sat, Feb 11, 2017 at 5:14 PM, John Beard <john.j.beard@xxxxxxxxx> wrote:
> Hi,
>
> Here is a branch with a GAL action to invoke the block select dialog
> and filter the current selection based on the results:
>
> https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/select_filter
>
> The first commit refactors the dialog so it can be reached by the GAL
> too, the second plumbs it in to the GAL selection tool. I have used
> 'Shift-F' to invoke the dialog.
>
> Possibly controversial: use of a compilation firewall (PImpl
> idiom/opaque pointer) to allow SELECTION_TOOL to keep an instance of
> the dialog options for persistance between invocations. As the class
> is a nested class, it can't be simply forward declared.
>
> If it is preferred to not use PImpl in this way (since it's not
> commonly done in Kicad), I can redo it so the options class is not
> nested and forward declare it.
>
> Cheers,
>
> John