← Back to team overview

kicad-developers team mailing list archive

Re: quick fix for legacy_plugin.cpp import of legacy sch files, Version: (2017-02-21 revision 8bed8af)-master, debug build

 

This doesn't look correct to me.  The original parser code for global
and hierarchical labels both show parsing the "Italic" keyword (see
eeschema/sch_text.cpp).  @JP, does this make sense to you or am I
missing something?  @Lachlan, if you have a schematic that is not being
properly parsed, please post it or a minimal example showing the bug.

On 2/21/2017 8:19 PM, Lachlan Audas wrote:
> Bug:  importing legacy sch file's   fails  on global labels, because
> code checks for "~" or "italics" on global
> labels,  when they have no such option.
> 
> Fix bypass's check for global labels
> 
> Application: kicad
> Version: (2017-02-21 revision 8bed8af)-master, debug build
> Libraries: wxWidgets 3.0.2
>            libcurl/7.38.0 OpenSSL/1.0.1t zlib/1.2.8 libidn/1.29
> libssh2/1.4.3 librtmp/2.3
> Platform: Linux 3.16.0-4-amd64 x86_64, 64 bit, Little endian, wxGTK
> - Build Info -
> wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
> Boost: 1.55.0
> Curl: 7.38.0
> KiCad - Compiler: GCC 4.8.4 with C++ ABI 1002
>         Settings: USE_WX_GRAPHICS_CONTEXT=OFF
>                   USE_WX_OVERLAY=OFF
>                   KICAD_SCRIPTING=ON
>                   KICAD_SCRIPTING_MODULES=OFF
>                   KICAD_SCRIPTING_WXPYTHON=OFF
>                   KICAD_SCRIPTING_ACTION_MENU=OFF
>                   BUILD_GITHUB_PLUGIN=ON
>                   KICAD_USE_OCE=OFF
> 
> 
> Lachlan
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References