kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hey Robert,

I merged your patch into the master branch.  Thank you for your
contribution.  I didn't see the tooltip pop up when I hovered over the
"User origin" control (windows 7 pro) so I'm not sure what's going on
there.  We can always make changes in subsequent patches if the
terminology is confusing.

Cheers,

Wayne

On 4/22/2017 4:30 PM, Robbert Lagerweij wrote:
> Wayne,
> 
> 
> I finally came around to updating the patch.
> 
> 
> I have not found a better term than "user origin" so I added a tooltip.
> I'm very much open to suggestions for better a term from anyone with a
> good idea. In any case, I intend to contribute a description of the new
> functionality and the different origins to the pcbnew documentation so
> that users can at least look up what is meant if it is unclear.
> 
> 
> As always, happy to incorporate anyones feedback if this can be improved.
> 
> 
> Kind regards,
> 
> 
> Robbert
> 
> 
> 
> ------------------------------------------------------------------------
> *From:* Wayne Stambaugh <stambaughw@xxxxxxxxx>
> *Sent:* Wednesday, March 22, 2017 4:59 PM
> *To:* Robbert Lagerweij; KiCad Developers
> *Subject:* Re: [Kicad-developers] [Patch] Add an option to select a
> reference point and an anchor in pcbnew move exactly dialog
>  
> Robbert,
> 
> To make life easier for both of us, I'm going to commit this patch as is
> as long as you are willing to create another patch with the following
> changes:
> 
> Rename "User origin" to something more descriptive or add a tool tip to
> prevent confusion.
> 
> Add a fifth option to move relative the to drill/place file origin.  I
> would actually find this option the most useful in my workflow.
> 
> I don't think greying out the user origin when it is not set is that
> important but I'll accept that change as well.  Let me know and I'll
> push your patch asap.
> 
> Thanks,
> 
> Wayne
> 
> On 3/22/2017 11:49 AM, Robbert Lagerweij wrote:
>> Thanks for the feedback Wayne.
>> 
>> In your test, did you explicitly set the user origin by pressing the
>> space bar? The user origin is set to ( 0,0 ) by default, so if you
>> haven't explicitly set the user origin to something else, it actually is
>> "correct" behavior to move relative to the sheet origin.
>> 
>> But now that you point it out, correct is not necessarily expected
>> behavior. I can add a check to see if the user origin is actually set
>> and disable the choice if it isn't.
>> 
>> Would that be a useful addition?
>> 
>> Robbert
>> 
>> Sent with Outlook for Android
>> 
>> 
>> ------------------------------------------------------------------------
>> *From:* Kicad-developers
>> <kicad-developers-bounces+rlagerweij=hotmail.com@xxxxxxxxxxxxxxxxxxx> on
>> behalf of Wayne Stambaugh <stambaughw@xxxxxxxxx>
>> *Sent:* Tuesday, March 21, 2017 4:51:36 PM
>> *To:* kicad-developers@xxxxxxxxxxxxxxxxxxx
>> *Subject:* Re: [Kicad-developers] [Patch] Add an option to select a
>> reference point and an anchor in pcbnew move exactly dialog
>>  
>> I did some quick testing on this and the move relative the user origin
>> always moves relative to the page origin.  Everything else appears to
>> work as expected.
>> 
>> On 3/20/2017 4:31 PM, Robbert Lagerweij wrote:
>>> Just a gentle bump on this patch. I have rebased it on master today. 
>>> 
>>> As said, I'm more than happy to rip out the legacy canvas stuff if this is the preference. Also happy to take on board any other comments or suggestions for changes.
>>> 
>>> Kind regards,
>>> 
>>> Robbert
>>> 
>>> 
>>> From: Robbert Lagerweij <rlagerweij@xxxxxxxxxxx>
>>> Sent: Tuesday, March 7, 2017 11:16 PM
>>> To: John Beard
>>> Cc: Tomasz Wlostowski; KiCad Developers
>>> Subject: Re: [Kicad-developers] [Patch] Add an option to select a reference point and an anchor in pcbnew move exactly dialog
>>>     
>>> Well, I finally had some time to look at improving this patch.
>>> 
>>> This version has the coding style policy issue fixed ( and uncrustified ). Inspired by Thomas' comment I removed some duplication in the selection_tool code.
>>> Given that I haven't received any further comments other than those of John, I've left the duplication between GAL and Legacy in.
>>> 
>>> Please let me know if anyone has any further suggestions to improve this.
>>> 
>>> Robbert
>>> 
>>> From: John Beard <john.j.beard@xxxxxxxxx>
>>> Sent: Tuesday, February 28, 2017 2:08 PM
>>> To: Robbert Lagerweij
>>> Cc: Tomasz Wlostowski; KiCad Developers
>>> Subject: Re: [Kicad-developers] [Patch] Add an option to select a reference point and an anchor in pcbnew move exactly dialog
>>>     
>>> On Tue, Feb 28, 2017 at 9:00 PM, Robbert Lagerweij
>>> <rlagerweij@xxxxxxxxxxx> wrote:
>>>> Hi Thomas,
>>>>
>>>> Thank you for your feedback. The duplication of code is indeed not how I
>>>> would usually approach this but I thought it the lesser of two evils given
>>>> the fact that the legacy stuff will most likely be deprecated immediately
>>>> after the 5.0 release. This means that long term maintainability is not
>>>> really affected since there will be limited chance of structural changes
>>>> needed to that part of the code (presumably only 5.x bug fixes) .
>>> 
>>> Since the work is done already in Legacy, I'd vote to leave it in.
>>> Duplicating code is paradoxically probably the cleanest way, as when
>>> legacy gets the chop, the GAL code will be unaffected. Combining the
>>> code is probably more likely to need tidying up in future that isn't
>>> just deleting one of the call sites.
>>> 
>>>> If we go the GAL only route, since legacy and GAL use the same dialog, I
>>>> could either create a new dialog which we only use in GAL or add additional
>>>> logic to disable/hide the functionality in legacy.
>>> 
>>> I think a new dialog is overkill and not worth the effort since the
>>> legacy work is done. At most, a constructor parameter to hide relevant
>>> UI controls would suffice, and be easy to rip out later.
>>> 
>>> Cheers,
>>> 
>>> John
>>>         
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
> KiCad Developers in Launchpad <https://launchpad.net/~kicad-developers>
> launchpad.net
> This is the team working on development of the KiCad EDA application
> suite. This team has its own mailing list, which is used to discuss
> ideas and plan progress: http ...
> 
> 
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
> KiCad Developers in Launchpad <https://launchpad.net/~kicad-developers>
> launchpad.net
> This is the team working on development of the KiCad EDA application
> suite. This team has its own mailing list, which is used to discuss
> ideas and plan progress: http ...
> 
> 
>>> More help   : https://help.launchpad.net/ListHelp
> ListHelp - Launchpad Help <https://help.launchpad.net/ListHelp>
> help.launchpad.net
> Launchpad allows a team to set up a discussion mailing list which is
> open to all members of the team. For the technically minded, Launchpad
> mailing lists are managed ...
> 
> 
>>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
> KiCad Developers in Launchpad <https://launchpad.net/~kicad-developers>
> launchpad.net
> This is the team working on development of the KiCad EDA application
> suite. This team has its own mailing list, which is used to discuss
> ideas and plan progress: http ...
> 
> 
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
> KiCad Developers in Launchpad <https://launchpad.net/~kicad-developers>
> launchpad.net
> This is the team working on development of the KiCad EDA application
> suite. This team has its own mailing list, which is used to discuss
> ideas and plan progress: http ...
> 
> 
>> More help   : https://help.launchpad.net/ListHelp
> ListHelp - Launchpad Help <https://help.launchpad.net/ListHelp>
> help.launchpad.net
> Launchpad allows a team to set up a discussion mailing list which is
> open to all members of the team. For the technically minded, Launchpad
> mailing lists are managed ...
> 
>