← Back to team overview

kicad-developers team mailing list archive

  1. kicad-developers team
  2. Mailing list archive
  3. Message #29662

Re: pull default PDF viewer

  Thread Previous • Date Previous • • Thread Next 
This seems wrong to me.  The schematic editor should not be looking at
the document field in the associated LIB_PART object.  It should only be
looking at the document field in the SCH_COMPONENT object.  This also
revealed another bug.  It does not look like the LIB_PART document field
is being copied to the SCH_COMPONENT document field.  I notice this when
I saw the context menu entry for a SCH_COMPONENT object that had an
empty document field.  So there are multiple things wrong here.  I will
fix these when I get a chance.

On 6/7/2017 11:27 AM, Fabrizio Tappero wrote:
> I noticed this problem in the past. also never really unrstood how to
> handle that often two PDF documentation files are often defined (one in
> the lib component properties) and one in the schematic comp properties.
> I am really not sure how the two are defined. I assume you are talking
> about the schedit.cpp portion
> 
>     case ID_POPUP_SCH_DISPLAYDOC_CMP:
> 
>         // Ensure the struct is a component (could be a piece of a
> component, like Field, text..)
>         if( item && item->Type() == SCH_COMPONENT_T )
>         {
>             if( PART_LIBS* libs = Prj().SchLibs() )
>             {
>                 LIB_ALIAS* entry = libs->FindLibraryAlias( (
> (SCH_COMPONENT*) item )->GetLibId() );
> 
>                 if( entry && !!entry->GetDocFileName() )
>                 {
>                     SEARCH_STACK* lib_search = Prj().SchSearchS();
> 
>                     GetAssociatedDocument( this,
> entry->GetDocFileName(), lib_search );
>                 }
>             }
>         }
>         break;
> 
> 
> cheers
> Fabrizio
> 
> 
> 
> On Wed, Jun 7, 2017 at 5:05 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Fabrizio,
> 
>     Thanks for testing this on Linux.  There is no need to send me a patch.
>     I verified that this did not break the windows system default pdf viewer
>     so I already have the change made.  I'm hoping it doesn't break anything
>     on osx.  I will give you credit for the commit.
> 
>     In a related note, I found that the symbol context menu entry "Open
>     Documentation" in Eeschema opens the documentation file defined by the
>     symbol library (LIB_PART) rather than the documentation file defined by
>     the schematic symbol (SCH_COMPONENT).  This needs to be fixed as well.
> 
>     Cheers,
> 
>     Wayne
> 
>     On 6/7/2017 10:45 AM, Fabrizio Tappero wrote:
>     > ​works great! I'll submit a patch in a sec.
>     >
>     > cheers
>     > Fabrizio
>     > ​
>     >
>     > On Wed, Jun 7, 2017 at 2:03 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>> wrote:
>     >
>     >     Fabrizio,
>     >
>     >     Try replacing wxMimeTypeManager with wxLaunchDefaultApplication[1].  It
>     >     looks like this might be a better solution.  I would try it myself but
>     >     I'm at work and don't have access to a linux system.
>     >
>     >     Cheers,
>     >
>     >     Wayne
>     >
>     >     [1]:
>     >     http://docs.wxwidgets.org/trunk/group__group__funcmacro__misc.html#ga04038d4c78e4c111d018b8f82b2d66c3
>     <http://docs.wxwidgets.org/trunk/group__group__funcmacro__misc.html#ga04038d4c78e4c111d018b8f82b2d66c3>
>     >     <http://docs.wxwidgets.org/trunk/group__group__funcmacro__misc.html#ga04038d4c78e4c111d018b8f82b2d66c3
>     <http://docs.wxwidgets.org/trunk/group__group__funcmacro__misc.html#ga04038d4c78e4c111d018b8f82b2d66c3>>
>     >
>     >     On 6/7/2017 3:37 AM, Fabrizio Tappero wrote:
>     >     > Hi Wayne,
>     >     > it is indeed checked and it appears to be a 2 year old bug.....
>     >     >
>     >     > http://thread.gmane.org/gmane.comp.lib.wxwidgets.devel/162783
>     <http://thread.gmane.org/gmane.comp.lib.wxwidgets.devel/162783>
>     >     <http://thread.gmane.org/gmane.comp.lib.wxwidgets.devel/162783
>     <http://thread.gmane.org/gmane.comp.lib.wxwidgets.devel/162783>>
>     >     >
>     >     > Any idea of how to properly fix this problem?
>     >     >
>     >     > cheers
>     >     > Fabrizio
>     >     >
>     >     >
>     >     >
>     >     > On Tue, Jun 6, 2017 at 7:58 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
>     >     > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>> wrote:
>     >     >
>     >     >     On 6/6/2017 4:17 AM, Fabrizio Tappero wrote:
>     >     >     > ​Apologies for presenting this problem again and again
>     >     >     >
>     >     >     >  I think this topic came up too many times but (on my
>     linux
>     >     system) the
>     >     >     > default PDF viewer is not pulled correctly by kiCad. From
>     >     the terminal:
>     >     >     >
>     >     >     > $ cat /usr/share/applications/defaults.list  | grep pdf
>     >     >     >
>     application/pdf=xreader.desktop;evince.desktop;atril.desktop
>     >     >
>     >     >     Is this the same as the mime type?  Look at another app
>     such as
>     >     >     Thunderbird and see what app it uses to open PDF files.
>     >     >
>     >     >     >
>     >     >     > but KiCad insist using Gimp.
>     >     >
>     >     >     Is Preferences->PDF Viewer->System Default PDF Viewer in
>     the KiCad
>     >     >     launcher checked?  If not, KiCad will attempt to fall
>     back on some
>     >     >     reasonable default.  If it is checked, then there is most
>     >     likely a bug
>     >     >     in wxMimeTypeManager which is used to determine the system
>     >     command to
>     >     >     open a PDF file.
>     >     >
>     >     >     >
>     >     >     > can anybody point me to the right direction? I am
>     looking at
>     >     preferences.cpp
>     >     >
>     >     >     The source file you are looking for is
>     common/gestfich.cpp.  The
>     >     >     function is OpenPDF().
>     >     >
>     >     >     >
>     >     >     > Cheers
>     >     >     > Fabrizio​
>     >     >     >
>     >     >     >
>     >     >     > _______________________________________________
>     >     >     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
>     >     >     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>>
>     >     >     >
>     >     >
>     >     >     _______________________________________________
>     >     >     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>     >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
>     >     >     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>
>     >     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >     <https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>>>
>     >     >     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>
>     >     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >     <https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>>>
>     >     >
>     >     >
>     >
>     >
> 
>

References

  Thread Previous • Date Previous • • Thread Next