← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Use wxImage instead of wxBitmap in COLOR4D picker (Fixes LP:1718389)

 

Nice catch!

On Sep 29, 2017 08:17, "Seppe Stas" <seppestas@xxxxxxxxx> wrote:

> The problem is caused by the alpha channel of KIGFX::COLOR4D being
> initialised to 0. This causes the color pickers to be invisible if the
> alpha channel is not set. I sent a patch for this in a separate thread.
>
> macOS is actually the only platform where the color picker behaves
> correctly XD. Ubuntu Unity and Windows seem to just ignore the alpha
> channel (did not test on any other platforms).
>
>
>
>
> On 29 September 2017 at 10:59:03, jp charras (jp.charras@xxxxxxxxxx)
> wrote:
>
> Le 29/09/2017 à 01:33, Jon Evans a écrit :
> > Hi all,
> >
> > The COLOR4D_PICKER_DLG has not been working on macOS [1].
> >
> > Through some experimentation, I found that drawing to a wxBitmap in
> createRGBBitmap() /
> > createHSVBitmap() just doesn't work on macOS.  I am not sure how to fix
> it, but I did find out that
> > drawing to a wxImage works just fine, so in the attached patch I switch
> those two methods to use
> > wxImage.
> >
> > If anyone can figure out why the wxBitmap stuff works on Windows/Linux
> but not macOS, maybe there is
> > a simpler way to fix this, but if not, the patch could be a good
> workaround (maybe it's a wx bug?)
> >
> > -Jon
>
> Thanks Jon for having a look into this issue.
> Using alpha channel in wxImage+wxBitmap creates issues( not visible
> cursors and axis outside the
> palettes, and incorrect color of cursors)
>
> I removed the alpha channel.
>
> Please, can you test this patch on macOS ?
>
> Thanks.
>
>
> --
> Jean-Pierre CHARRAS
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>

References