kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

This seems like a reasonable solution.  Although pointing macOS
developers to the repo might be an issue.

On a related note, I was just updating the compiling.md file and noticed
that there seem to be quite a few of the macos wxWidgets patches not
mentioned in the "Building KiCad on macOS" section.  I'm guessing this
needs to be updated.

On 12/29/2017 05:27 PM, Bernhard Stegmaier wrote:
> To be honest, I don’t like the patches as is at all.
> You never know if patches are still need if there are new versions or if they still do apply.
> 
> IMHO it would be a better solution if someone would maintain a fork of wxwidgets (e.g., on GitHub) with all the needed patches applied, so that someone who really wants to build just has to sync this… ?
> For myself, I do this quite some time so I don’t have to apply all the patches every time (for wxWidgets master).
> 
> 
> Regards,
> Bernhard
> 
>> On 29. Dec 2017, at 22:07, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> I think the main reason why this happens is that most of those patches
>> are not created by KiCad devs, but rather taken from upstream mailing
>> lists, and I have always just preserved the patch as is, but I don't
>> have a strong opinion on keeping it like it is or changing it to be
>> more consistent.
>>
>> I don't mind how it would get changed, as long as, if it gets changed,
>> it gets more consistent between the different patches and between the
>> patches and the docs.
>>
>> Adam Wolf
>>
>> On Fri, Dec 29, 2017 at 2:37 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>> Any of our osx devs have an opinion on this?  It doesn't impact me so I
>>> would rather the devs who have to use this make the call.
>>>
>>> On 12/29/2017 03:33 PM, Anton Shevchenko wrote:
>>>> Hi all,
>>>>
>>>> Looking through the code style guide (i'm new here) I didn't find a word about how a patch file should reference source code file. By patch file I mean *.patch file located in kicad/patches folder.
>>>>
>>>> Being on macOS I'm trying to apply all the patches required for building wxWidgets and have found that there are 2 different styles in use.
>>>> First style references source code files without prefix. To apply such a patch one has to run 'patch -p0'.
>>>> The other style uses a/ and b/ prefixes which is used with 'patch -p1' option.
>>>> In my opinion the last one is more common (and if you run 'git diff' you will see a/ and b/ prefixes).
>>>>
>>>> I would like to fix macOS patches stuff to be able to actually follow the guide (http://docs.kicad-pcb.org/doxygen/md_Documentation_development_compiling.html#build_osx) in order to build KiCad for macOS.
>>>>
>>>> Any comments?
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>