kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

Hi JP,

I was able to see the problem you described, and the attached change seems
to fix it.

-Jon

On Sat, Jan 6, 2018 at 11:40 AM, jp charras <jp.charras@xxxxxxxxxx> wrote:

> Le 06/01/2018 à 15:47, Jon Evans a écrit :
> > Hi JP,
> >
> > I think the attached is a better fix.
> >
> > -Jon
>
> It works fine.
> I committed your patch. Thanks.
>
> Could you have a look at a minor issue on Cairo:
> when switching to Cairo or after modifying the background color, the
> screen is not immediately updated:
> it is updated as soon as the mouse cursor is moved on the canvas.
> (At least on W7 32bits)
> Thanks.
>
> --
> Jean-Pierre CHARRAS
>

From b77f6d3439230c84d52df1ddd8f2f51720521cd1 Mon Sep 17 00:00:00 2001
From: Jon Evans <jon@xxxxxxxxxxxxx>
Date: Sat, 6 Jan 2018 16:16:24 -0500
Subject: [PATCH] Force a refresh when changing render colors

This fixes Cairo not updating until mouse is moved over the canvas
---
 pcbnew/class_pcb_layer_widget.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pcbnew/class_pcb_layer_widget.cpp b/pcbnew/class_pcb_layer_widget.cpp
index 9e979d271..6e2af9410 100644
--- a/pcbnew/class_pcb_layer_widget.cpp
+++ b/pcbnew/class_pcb_layer_widget.cpp
@@ -645,7 +645,7 @@ void PCB_LAYER_WIDGET::OnRenderColorChange( int aId, COLOR4D aColor )
         if( aId == LAYER_PCB_BACKGROUND )
             view->UpdateLayerColor( LAYER_PADS_PLATEDHOLES );
 
-        galCanvas->Refresh();
+        galCanvas->ForceRefresh();
     }
 
     myframe->GetCanvas()->Refresh();
-- 
2.14.1