kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi Jon,

On 01/16/2018 05:09 AM, Jon Evans wrote:
> SELECTION_AREA::ViewDraw() doesn't set the line width.  I thought about
> fixing it by adding a call to set some kind of arbitrary width, but decided
> to do it a different way to be more generally applicable.  Despite my
> saying that, this is still more of a workaround than a real fix.

Many thanks for the patch. I added one more to fix another aspect of the
bug and pushed both changes to the master branch.

> Note that this is probably a topic that wants future thought after V5:
> There is currently no easy way to draw things in screen space rather than
> world space.  Maybe I will think about how to add an easy-to-use mechanism
> to the GAL to accomplish this.  Sometimes you really just want a line that
> is 1px wide ;-)

I agree. Some time ago Oliver has sent a patch to enable selecting line
width in screen units, but it would not work for items cached in the
video memory. Then I developed a new shader to fix this issue as well,
but I was still getting some visual artifacts. If you are interested,
work in progress code is in my launchpad repository [1].

Cheers,
Orson

1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/gal_fixed_line

> Fixes: https://bugs.launchpad.net/kicad/+bug/1743242
> 
> -Jon
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature