kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

Hi Simon,

I haven't had a chance to review and test your updated patch yet, and I
suspect the other devs are also busy trying to get 5.0 out the door.
But there are still a lot of code style issues that need to be fixed
(indentation needs to be spaces and you use tabs for one example, and there
are some other formatting issues)
I know this might seem annoying but it's important that we keep the whole
KiCad codebase styled the same way.

I suggest you keep your work in a Git branch that you can rebase on top of
KiCad master, since we won't be able to consider merging your code into
master until after the 5.0 release.

I'm not sure what you mean about the thread, maybe this is a thing about
your mail client?  I don't see those threads merged.

Best,
Jon

On Fri, Mar 23, 2018 at 4:36 AM, Simon Santesteban <tech@xxxxxxxxxxxx>
wrote:

> I am looking into adding zone keepout edition in inner layers, in the
> module editor, but first I would like to confirm that my previous work is
> ok.
>
> Do you know how a patch is validated? Do I need to do anything else?
>
>
> Also, I noticed that this thread ('Zone keepouts within modules') has been
> incorporated to thread '3D search paths and environment variables', but I
> don't see the similarity...
>
>
> Thanks,
>
>
> Simon
>
> On 20/03/2018 1:55, Simon Santesteban wrote:
>
> Hi Jon,
>
> Oh yes I missed some of the code style policy...
>
> I have attached an updated patch.
>
>
> Regards,
>
>
> Simon
>
> El 19/03/2018 a las 21:07, Jon Evans escribió:
>
> Hi Simon,
>
> Thanks for the updated patch, I was able to give it a quick try and it so
> far I haven't found any issues (I edited a footprint to create a keepout,
> and then saw that it correctly caused DRC warnings)
>
> I noticed a number of coding style policy issues with your patch though;
> these would have to be fixed before it is merged.
> (some issues with spacing around parentheses, use of tabs instead of
> spaces, etc)
> See here for details:
> https://kicad-source-mirror.readthedocs.io/en/stable/
> Documentation/development/coding-style-policy/
>
> Best,
> Jon
>
> On Mon, Mar 19, 2018 at 2:11 PM, Simon Santesteban <tech@xxxxxxxxxxxx>
> wrote:
>
>> I think I have it updated correctly now. There was a conflict in
>> pcbnew/menubar_footprint_editor.cpp
>>
>> See patch attached.
>>
>> Simon
>>
>> El 19/03/2018 a las 15:28, Jon Evans escribió:
>>
>> Hi Simon,
>>
>> Thanks for sharing your work! This sounds like a neat feature and I'd
>> like to test it and give feedback.
>> Unfortunately your patch does not apply against current master, and it
>> looks like it is based on an old enough point that I couldn't fix the merge
>> issues manually.
>> Could you please rebase your patch against the latest master and re-send
>> it?
>>
>> Please note in case you haven't been following the developer list, we are
>> in feature freeze for the 5.0 release and so we would only be able to merge
>> new features like this once 6.0 development starts, so you'll likely need
>> to rebase it once more before it can be merged at that point.
>>
>> Thanks,
>> Jon
>>
>> On Mon, Mar 19, 2018 at 8:02 AM, Simon Santesteban <tech@xxxxxxxxxxxx>
>> wrote:
>>
>>> Hi everyone,
>>>
>>> I am a new developer in kicad community. I have been working on adding
>>> zones to modules, so I would like to share this work.
>>> Find attached a patch to have this functionality.
>>>
>>> Regards,
>>>
>>> Simon
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> --
> Simon Santesteban
> Director Técnico
> Embeblue
> Correo: tech@xxxxxxxxxxxx
> WEB: www.embeblue.com
> Teléfono: 948 96 96 86
> ------------------------------------
>
> Este mensaje de correo electrónico y sus documentos adjuntos están dirigidos exclusivamente a los destinatarios especificados.
> Si usted recibe este mensaje por error, por favor comuníqueselo inmediatamente al remitente y elimínelo ya que usted no está autorizado al uso,
> relevación, distribución, impresión o copia de toda o alguna parte de la información contenida. Gracias.
> De conformidad con la Ley de Orgánica de Protección de Datos de Carácter Personal 15/1999, de 13 de diciembre,
> le recordamos que sus datos han sido incorporados en un fichero de datos de carácter personal del que es titular EMBEBLUE SL,
> debidamente registrado ante la AEPD y cuya finalidad es gestionar comunicaciones internas y externas vía electrónica.
> Así mismo, le informamos que sus datos no serán cedidos a terceros sin su consentimiento.
> Puede ejercitar sus derechos de acceso, rectificación, cancelación y oposición en Calle Iturriondoa 1 <https://maps.google.com/?q=Calle+Iturriondoa+1&entry=gmail&source=g> bajo – 31620 Huarte (Navarra)
> o bien en la siguiente dirección de correo electrónico: info@xxxxxxxxxxxx
>
>