kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #35200
Re: [PATCH] Fix for bug/1754049
Le 26/03/2018 à 21:58, Maciej Suminski a écrit :
> Hi Jean-Pierre,
>
>>>> -Not so minor issues:
>>>> Multilayers items (blind/buried vias, keepout zones) are incorrectly handled:
>>>> * In GAL mode, removed Multilayers items are still visible after deletion.
>>>
>>> This should be fixed. Even if it's something as crude as checking to
>>> make sure the layer actually exists in the board before drawing an
>>> object in gal.
>>
>> I am certainly not a GAL specialist, but it is just a cache rebuild issue.
>>
>> However, apart GAL issue, Multilayers items are not correctly handled, because they are deleted
>> regardless they are still existing on not deleted layers.
>
> I have just done the following:
> - set number of copper layers to 8
> - placed a few buried vias between In2.Cu (3rd layer from the top) and
> In5.Cu (3rd layer from the bottom)
>
> Now when I decrease the number of Cu layers to 4, the vias remain but
> have the target layer undefined as In5.Cu does not exist anymore. Once I
> reduce the number of Cu layers to 2, they disappear. Restoring the
> original number of layers brings them back.
>
> Is that what you see as well? As far as I understand, the items are not
> deleted as they are restored once the required layers are available. How
> to trigger the issues you describe?
>
> Regards,
> Orson
I just committed a first fix that fixes a few issues.
Currently, a bug is still pending: a crash can happen if a undo command uses a removed item.
About vais, that are multilayers items, blind/ buried vias and especially micro vias are a tricky case.
Currently they are removed (due to a small bug in code) if they start on a removed layer.
But the actual problem is: Should we remove them if they are still living on existing layers?
And if not should we modify the layer pair.
Micro vias for instance are blind vias connecting 2 adjacent layers, so we could modify easily the
layer pair without removing them.
--
Jean-Pierre CHARRAS
Follow ups
References
-
[PATCH] Fix for bug/1754049
From: hauptmech, 2018-03-14
-
Re: [PATCH] Fix for bug/1754049
From: Seth Hillbrand, 2018-03-14
-
Re: [PATCH] Fix for bug/1754049
From: hauptmech, 2018-03-18
-
Re: [PATCH] Fix for bug/1754049
From: Seth Hillbrand, 2018-03-19
-
Re: [PATCH] Fix for bug/1754049
From: Eeli Kaikkonen, 2018-03-20
-
Re: [PATCH] Fix for bug/1754049
From: Wayne Stambaugh, 2018-03-21
-
Re: [PATCH] Fix for bug/1754049
From: jp charras, 2018-03-22
-
Re: [PATCH] Fix for bug/1754049
From: Andrey Kuznetsov, 2018-03-22
-
Re: [PATCH] Fix for bug/1754049
From: jp charras, 2018-03-22
-
Re: [PATCH] Fix for bug/1754049
From: hauptmech, 2018-03-22
-
Re: [PATCH] Fix for bug/1754049
From: Wayne Stambaugh, 2018-03-25
-
Re: [PATCH] Fix for bug/1754049
From: jp charras, 2018-03-26
-
Re: [PATCH] Fix for bug/1754049
From: Wayne Stambaugh, 2018-03-26
-
Re: [PATCH] Fix for bug/1754049
From: jp charras, 2018-03-26
-
Re: [PATCH] Fix for bug/1754049
From: Maciej Suminski, 2018-03-26