← Back to team overview

kicad-developers team mailing list archive

Re: Joy of multi-platform development

 

Le 12/08/2018 à 11:42, Jeff Young a écrit :
> Alt-BkSp works on OSX (performs a Leave Sheet), but does not show up in
> the menu:
> 
> 
> It does show up in the Show Hotkeys dialog:
> 

Hi Jeff,
Could you have a look into common/hotkeys_basic.cpp, and in the 2 lines:
263 and 324, modify
#ifdef  __LINUX__
to enable it also on OSX, and see if  Alt-BkSp still works and is shown
in menus.

Thanks.

> 
> 
>> On 9 Aug 2018, at 22:05, Jeff Young <jeff@xxxxxxxxx
>> <mailto:jeff@xxxxxxxxx>> wrote:
>>
>> I hope to have my tree back in working order tomorrow and could do
>> this then….
>>
>> Cheers,
>> Jeff.
>>
>>
>>> On 9 Aug 2018, at 20:36, Wayne Stambaugh <stambaughw@xxxxxxxxx
>>> <mailto:stambaughw@xxxxxxxxx>> wrote:
>>>
>>> On 8/9/2018 1:11 PM, jp charras wrote:
>>>> Le 09/08/2018 à 19:02, Wayne Stambaugh a écrit :
>>>>> On 8/9/2018 12:06 PM, jp charras wrote:
>>>>>> Eeschema uses accelerator key BkSp (exactly Alt+BkSp) in view menu
>>>>>> (View/Leave Sheet).
>>>>>>
>>>>>> This accelerator works fine on Windows, and generates a warning on
>>>>>> Linux
>>>>>> (and is not shown in menu)
>>>>>>
>>>>>> Reason:
>>>>>> On Linux (GTK?) the accelerator key BkSp, when used in menus must be
>>>>>> coded as "\t\b" and not "\tBkSp" (and the Alt+BkSp accelerator is
>>>>>> \tAlt+\b)
>>>>>> (\b is the ASCII code of Back Space key).
>>>>>> However, On Windows, Alt+BkSp accelerator must be "\tAlt+BkSp".
>>>>>>
>>>>>> I just fixed this minor issue in commit 78ab5c3f07
>>>>>> Can someone test this commit on OSX and see if "\tAlt+BkSp" is
>>>>>> working?
>>>>>> Thanks.
>>>>>>
>>>>>
>>>>> The gift that keeps on giving. ;)  Nice catch.  I wonder if the wx
>>>>> folks
>>>>> know this.  It would be nice if they fixed this one their end.
>>>>>
>>>>> This is probably the cause of this bug report:
>>>>>
>>>>> https://bugs.launchpad.net/kicad/+bug/1786113
>>>>>
>>>>> The fix for this should also be cherry picked into the 5.0 branch.
>>>>
>>>> Sure. I just need to know what happens on OSX.
>>>
>>> Would one of our osx devs please check this for JP?
>>>
>>> Thanks,
>>>
>>> Wayne
>>>
>>>>
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Wayne

-- 
Jean-Pierre CHARRAS


Follow ups

References