kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 26/09/2018 à 09:51, Константин Барановский a écrit :
> Hi Seth!
> 
> Something like this (see attachment)?
> Not sure that I done it right, but it works fine.

Hi Konstantin,

They are I18N strings. Are there correctly translated ?
Especially after switching to an other language.

Any translated string must be created on the fly to be correctly translated.

> 
> вт, 25 сент. 2018 г. в 22:24, <seth@xxxxxxxxxxxxx
> <mailto:seth@xxxxxxxxxxxxx>>:
> 
>     Hi Baranovskiy-
> 
>     On 2018-09-25 07:17, Baranovskiy Konstantin wrote:
>     > Nets dialog (Inspect->List Nets) contains list control
>     > that has very small width for first and last columns.
>     > Changed algorithm for calculating optimal values for
>     > column width.
>     > ---
>     >  .../dialogs/dialog_select_net_from_list.cpp   | 49
>     +++++++++++++++----
>     >  1 file changed, 39 insertions(+), 10 deletions(-)
>     >
>     > diff --git a/pcbnew/dialogs/dialog_select_net_from_list.cpp
>     > b/pcbnew/dialogs/dialog_select_net_from_list.cpp
>     > index 39a403b65..960c5afbd 100644
>     > --- a/pcbnew/dialogs/dialog_select_net_from_list.cpp
>     > +++ b/pcbnew/dialogs/dialog_select_net_from_list.cpp
>     > @@ -42,6 +42,10 @@
>     >  #include <pcb_painter.h>
>     >  #include <connectivity_data.h>
>     >
>     > +#define COLUMN_HEADER_NET   _( "Net" )
>     > +#define COLUMN_HEADER_NAME  _( "Name" )
>     > +#define COLUMN_HEADER_COUNT _( "Pad Count" )
> 
>     This is overall a good patch.  Can you replace the three defines here
>     with C++-style constexpr functions?
> 
>     -Seth
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


-- 
Jean-Pierre CHARRAS